Issue 12627043: Upgrades YUI to 3.11

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12627043: Upgrades YUI to 3.11

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
mp+179047, rharding, benji

Visibility:
Public.

Description

Upgrades YUI to 3.11 Also fixes a couple small issues exposed in the upgrade. https://code.launchpad.net/~hatch/juju-gui/yui-311/+merge/179047 (do not edit description out of merge proposal)

Patch Set 2 : Upgrades YUI to 3.11 #

Total comments: 1

Patch Set 3 : Upgrades YUI to 3.11 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+410 lines, -313 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	npm-shrinkwrap.json	View		23 chunks	+396 lines, -310 lines	0 comments	Download
M	package.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_app_hotkeys.js	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rharding

LGTM qa'd ok with the two known issues of the expose button not flipping and ...

10 years, 9 months ago (2013-08-08 14:18:03 UTC) #4

benji

LGTM and extensive QA looks good. Thanks! https://codereview.appspot.com/12627043/diff/4001/npm-shrinkwrap.json File npm-shrinkwrap.json (right): https://codereview.appspot.com/12627043/diff/4001/npm-shrinkwrap.json#newcode7 npm-shrinkwrap.json:7: "from": "cryptojs@>= ...

10 years, 9 months ago (2013-08-08 14:31:43 UTC) #5

jeff.pihach

10 years, 9 months ago (2013-08-08 14:42:29 UTC) #6

*** Submitted:

Upgrades YUI to 3.11

Also fixes a couple small issues exposed in the upgrade.

R=rharding, benji
CC=
https://codereview.appspot.com/12627043

Expand All Messages | Collapse All Messages