Issue 12623043: Adds a number of missing ghost inspector tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12623043: Adds a number of missing ghost inspector tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
benjamin.saller, j.c.sackett, mp+179037

Visibility:
Public.

Description

Adds a number of missing ghost inspector tests Also fixes a couple small issues and adds some documentation where things are confusing. https://code.launchpad.net/~hatch/juju-gui/rem-ghost-tests/+merge/179037 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adds a number of missing ghost inspector tests #

Patch Set 3 : Adds a number of missing ghost inspector tests #

Patch Set 4 : Adds a number of missing ghost inspector tests #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -8 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/ghost-config-viewlet.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/ghost-inspector.js	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	test/test_ghost_inspector.js	View	1	2 chunks	+93 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM, thanks https://codereview.appspot.com/12623043/diff/1/test/test_ghost_inspector.js File test/test_ghost_inspector.js (right): https://codereview.appspot.com/12623043/diff/1/test/test_ghost_inspector.js#newcode99 test/test_ghost_inspector.js:99: var handler = vmContainer.delegate('valuechange', function() { This ...

10 years, 9 months ago (2013-08-07 21:11:04 UTC) #3

jeff.pihach

Thanks very much for the reviews!! https://codereview.appspot.com/12623043/diff/1/test/test_ghost_inspector.js File test/test_ghost_inspector.js (right): https://codereview.appspot.com/12623043/diff/1/test/test_ghost_inspector.js#newcode99 test/test_ghost_inspector.js:99: var handler = ...

10 years, 9 months ago (2013-08-07 21:13:19 UTC) #4

jeff.pihach

10 years, 9 months ago (2013-08-07 22:07:46 UTC) #5

*** Submitted:

Adds a number of missing ghost inspector tests

Also fixes a couple small issues and adds some
documentation where things are confusing.

R=j.c.sackett, benjamin.saller
CC=
https://codereview.appspot.com/12623043

Expand All Messages | Collapse All Messages