Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(711)

Issue 12621043: Update autocomplete design and add categories

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rharding
Modified:
10 years, 9 months ago
Reviewers:
benjamin.saller, jeff.pihach, mp+179027
Visibility:
Public.

Description

Update autocomplete design and add categories - Update CSS to display the suggestion charm tokens nicely - Add helpers to add categories as completion options - This means we turn categories into charms, into charm-tokens - Add support for auto showing categories on first focus - Update the charm-token to allow overriding the icon url to get these category icons to show properly. - Update the events to make sure we can catch/parse categories clicked to perform a proper category 'search' and load results. Please QA! ---------- - Use the feature flag :flags:/ac - Verify that on click you get the categories off the bat - Entering part of a word ('a' for instance) lists both charm results and categories - Selecting a category should navigate to a category search as expected - Selecting a charm should perform a search with that charm's name and have that charm's details visible. https://code.launchpad.net/~rharding/juju-gui/ac3/+merge/179027 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update autocomplete design and add categories #

Total comments: 3

Patch Set 3 : Update autocomplete design and add categories #

Patch Set 4 : Update autocomplete design and add categories #

Patch Set 5 : Update autocomplete design and add categories #

Patch Set 6 : Update autocomplete design and add categories #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -53 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/browser.js View 1 chunk +3 lines, -3 lines 0 comments Download
M app/store/charm.js View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M app/subapps/browser/views/view.js View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M app/templates/charm-token.handlebars View 1 chunk +5 lines, -1 line 0 comments Download
M app/widgets/charm-search.js View 1 2 3 4 11 chunks +134 lines, -42 lines 0 comments Download
M app/widgets/charm-token.js View 2 chunks +14 lines, -0 lines 0 comments Download
M lib/views/browser/charm-token.less View 1 chunk +19 lines, -0 lines 0 comments Download
M test/test_browser_search_widget.js View 1 2 3 4 3 chunks +68 lines, -2 lines 0 comments Download
M test/test_charm_store.js View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M test/test_charm_token.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M test/test_filter_widget.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10
rharding
Please take a look.
10 years, 9 months ago (2013-08-08 13:55:30 UTC) #1
jeff.pihach
This is looking good! QA issues: search for 'cep' you'll get three results, click away ...
10 years, 9 months ago (2013-08-08 14:23:31 UTC) #2
rharding
On 2013/08/08 14:23:31, jeff.pihach wrote: > This is looking good! > > QA issues: > ...
10 years, 9 months ago (2013-08-08 14:34:52 UTC) #3
rharding
Please take a look.
10 years, 9 months ago (2013-08-08 15:24:33 UTC) #4
rharding
> > search for 'cep' you'll get three results, click away from the input, now ...
10 years, 9 months ago (2013-08-08 15:26:34 UTC) #5
rharding
Please take a look.
10 years, 9 months ago (2013-08-08 15:27:53 UTC) #6
jeff.pihach
LGTM Thanks for those fixes! This is a great feature
10 years, 9 months ago (2013-08-08 15:49:38 UTC) #7
rharding
Please take a look.
10 years, 9 months ago (2013-08-08 15:56:49 UTC) #8
benjamin.saller
LGTM, QA seems good Thanks for this.
10 years, 9 months ago (2013-08-08 16:27:23 UTC) #9
rharding
10 years, 9 months ago (2013-08-08 16:54:10 UTC) #10
*** Submitted:

Update autocomplete design and add categories

- Update CSS to display the suggestion charm tokens nicely
- Add helpers to add categories as completion options
- This means we turn categories into charms, into charm-tokens
- Add support for auto showing categories on first focus
- Update the charm-token to allow overriding the icon url to get these
category icons to show properly.
- Update the events to make sure we can catch/parse categories clicked to
perform a proper category 'search' and load results.

Please QA!
----------

- Use the feature flag :flags:/ac
- Verify that on click you get the categories off the bat
- Entering part of a word ('a' for instance) lists both charm results and
categories
- Selecting a category should navigate to a category search as expected
- Selecting a charm should perform a search with that charm's name and have
that charm's details visible.

R=jeff.pihach, benjamin.saller
CC=
https://codereview.appspot.com/12621043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b