code review 126210046: runtime: convert async semaphores to Go

runtime: convert async semaphores to Go

[dvyukov, 2014-08-24 16:09:18]

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[rsc, 2014-08-24 18:20:17]

LGTM

It would be nice in future conversions if you kept the two files in the same
order. Comparing sema.goc and sema.go here I had to keep jumping around in the
files.

https://codereview.appspot.com/126210046/diff/60001/src/pkg/runtime/sema.go
File src/pkg/runtime/sema.go (right):

https://codereview.appspot.com/126210046/diff/60001/src/pkg/runtime/sema.go#n...
src/pkg/runtime/sema.go:152: s.link = nil
please rename link to next.
it was next in the original code, which is reason enough.
but prev/next is also much better than prev/link in a doubly linked list.
i let this slide in the last CL but that was a mistake - i hadn't noticed it was
a doubly linked list.

[dvyukov, 2014-08-25 11:58:04]

https://codereview.appspot.com/126210046/diff/60001/src/pkg/runtime/sema.go
File src/pkg/runtime/sema.go (right):

https://codereview.appspot.com/126210046/diff/60001/src/pkg/runtime/sema.go#n...
src/pkg/runtime/sema.go:152: s.link = nil
On 2014/08/24 18:20:17, rsc wrote:
> please rename link to next.
> it was next in the original code, which is reason enough.
> but prev/next is also much better than prev/link in a doubly linked list.
> i let this slide in the last CL but that was a mistake - i hadn't noticed it
was
> a doubly linked list.


Sync semaphores in the last CL use singly-linked list, so sudog.link was ok for
them.
Done

[rsc, 2014-08-25 16:11:14]

LGTM

[dvyukov, 2014-08-25 16:12:32]

*** Submitted as https://code.google.com/p/go/source/detail?r=3f13ed48b37e ***

runtime: convert async semaphores to Go

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews, khr
https://codereview.appspot.com/126210046

[gobot, 2014-08-25 16:23:54]

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/9c9258687db44f6ec7947b59edbbb1becc4577af