Issue 12620044: Fix IE CI Failures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12620044: Fix IE CI Failures

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
benjamin.saller, mp+179071

Visibility:
Public.

Description

Fix IE CI Failures YUI's simulate() doesn't support focus or blur in IE10 and attempts to rapidly patch the simulate system to use native events for the valuechange have not been successful so until YUI fixes this properly we have to skip these tests in IE10. https://code.launchpad.net/~hatch/juju-gui/fix-ie-ci-failure/+merge/179071 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix IE CI Failures #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/test_conflict_ux.js	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	test/test_ghost_inspector.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM, thanks for including the comment on each of those.

10 years, 9 months ago (2013-08-07 23:58:04 UTC) #2

jeff.pihach

10 years, 9 months ago (2013-08-08 00:13:15 UTC) #4

*** Submitted:

Fix IE CI Failures

YUI's simulate() doesn't support focus or blur in IE10
and attempts to rapidly patch the simulate system to use
native events for the valuechange have not been successful
so until YUI fixes this properly we have to skip these
tests in IE10.

R=benjamin.saller
CC=
https://codereview.appspot.com/12620044

Expand All Messages | Collapse All Messages