Issue 12616043: fix es53 fatal error on css3 transition-property

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12616043: fix es53 fatal error on css3 transition-property (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by felix8a

Modified:
12 years, 8 months ago

Reviewers:
MikeSamuel

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

to support css3 transition-property, the css sanitizer has a new atom <property-name> that isn't handled by the es53 css sanitizer, so it throws a SomethingWidgyHappenedError. In this CL I'm just treating <property-name> as a synonym for <identifier>, because the difference is not particularly security-critical, and es53 is going away anyway.

Patch Set 1 #

Total comments: 1

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	src/com/google/caja/plugin/CssValidator.java	View		1 chunk	+8 lines, -0 lines	1 comment	Download
	M	tests/com/google/caja/plugin/CssValidatorTest.java	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

MikeSamuel

LGTM https://codereview.appspot.com/12616043/diff/1/src/com/google/caja/plugin/CssValidator.java File src/com/google/caja/plugin/CssValidator.java (right): https://codereview.appspot.com/12616043/diff/1/src/com/google/caja/plugin/CssValidator.java#newcode1305 src/com/google/caja/plugin/CssValidator.java:1305: // TODO(felix8a): duplicate the restriction in sanitizecss.js Ah. ...

12 years, 8 months ago (2013-08-07 21:09:14 UTC) #2

@r5536

Expand All Messages | Collapse All Messages