code review 12614043: test: fix return.go to not use fallthrough in a type switch

test: fix return.go to not use fallthrough in a type switch

The gc compiler only gives an error about fallthrough in a
type switch if it has not given any errors in an earlier pass.
Remove all functions in this test that use fallthrough in a
type switch because they don't test anything useful and they
cause gccgo to give unexpected errors.

[iant, 2013-08-07 17:11:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-08-07 18:01:47]

LGTM



On Wed, Aug 7, 2013 at 10:11 AM, <iant@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> test: fix return.go to not use fallthrough in a type switch
>
> The gc compiler only gives an error about fallthrough in a
> type switch if it has not given any errors in an earlier pass.
> Remove all functions in this test that use fallthrough in a
> type switch because they don't test anything useful and they
> cause gccgo to give unexpected errors.
>
> Please review this at
https://codereview.appspot.**com/12614043/<https://codereview.appspot.com/126...
>
> Affected files:
>   M test/return.go
>
>
> Index: test/return.go
> ==============================**==============================**=======
> --- a/test/return.go
> +++ b/test/return.go
> @@ -666,17 +666,6 @@
>         }
>  }
>
> -func _() int {
> -       print(1)
> -       switch x.(type) {
> -       case int:
> -               print(2)
> -               fallthrough
> -       default:
> -               return 4
> -       }
> -}
> -
>  // if no default or some case doesn't terminate, switch is no longer okay
>
>  func _() int {
> @@ -713,17 +702,6 @@
>         switch x.(type) {
>         case int:
>                 print(2)
> -               fallthrough
> -       case float64:
> -               return 4
> -       }
> -} // ERROR "missing return"
> -
> -func _() int {
> -       print(1)
> -       switch x.(type) {
> -       case int:
> -               print(2)
>                 panic(3)
>         }
>  } // ERROR "missing return"
> @@ -1356,16 +1334,6 @@
>         }
>  }
>
> -func _() int {
> -       switch x.(type) {
> -       case int:
> -               print(2)
> -               fallthrough
> -       default:
> -               return 4
> -       }
> -}
> -
>  // if no default or some case doesn't terminate, switch is no longer okay
>
>  func _() int {
> @@ -1398,16 +1366,6 @@
>         switch x.(type) {
>         case int:
>                 print(2)
> -               fallthrough
> -       case float64:
> -               return 4
> -       }
> -} // ERROR "missing return"
> -
> -func _() int {
> -       switch x.(type) {
> -       case int:
> -               print(2)
>                 panic(3)
>         }
>  } // ERROR "missing return"
> @@ -2102,17 +2060,6 @@
>         }
>  }
>
> -var _ = func() int {
> -       print(1)
> -       switch x.(type) {
> -       case int:
> -               print(2)
> -               fallthrough
> -       default:
> -               return 4
> -       }
> -}
> -
>  // if no default or some case doesn't terminate, switch is no longer okay
>
>  var _ = func() int {
> @@ -2149,17 +2096,6 @@
>         switch x.(type) {
>         case int:
>                 print(2)
> -               fallthrough
> -       case float64:
> -               return 4
> -       }
> -} // ERROR "missing return"
> -
> -var _ = func() int {
> -       print(1)
> -       switch x.(type) {
> -       case int:
> -               print(2)
>                 panic(3)
>         }
>  } // ERROR "missing return"
> @@ -2792,16 +2728,6 @@
>         }
>  }
>
> -var _ = func() int {
> -       switch x.(type) {
> -       case int:
> -               print(2)
> -               fallthrough
> -       default:
> -               return 4
> -       }
> -}
> -
>  // if no default or some case doesn't terminate, switch is no longer okay
>
>  var _ = func() int {
> @@ -2834,16 +2760,6 @@
>         switch x.(type) {
>         case int:
>                 print(2)
> -               fallthrough
> -       case float64:
> -               return 4
> -       }
> -} // ERROR "missing return"
> -
> -var _ = func() int {
> -       switch x.(type) {
> -       case int:
> -               print(2)
>                 panic(3)
>         }
>  } // ERROR "missing return"
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[iant, 2013-08-07 18:05:27]

*** Submitted as https://code.google.com/p/go/source/detail?r=8febfb2350b4 ***

test: fix return.go to not use fallthrough in a type switch

The gc compiler only gives an error about fallthrough in a
type switch if it has not given any errors in an earlier pass.
Remove all functions in this test that use fallthrough in a
type switch because they don't test anything useful and they
cause gccgo to give unexpected errors.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12614043