code review 12613044: runtime: convert .s textflags from numbers to symbolic ...

runtime: convert .s textflags from numbers to symbolic constants.
Remove NOPROF/DUPOK from everything.

Edits done with a script, except pclinetest.asm which depended
on the DUPOK flag on main().

[khr, 2013-08-07 18:23:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[bradfitz, 2013-08-07 18:43:17]

LGTM

Builds on Mac and Linux too.



On Wed, Aug 7, 2013 at 11:23 AM, <khr@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://khr%40golang.org@code.**google.com/p/go/<http://40golang.org@code.goo...
>
>
> Description:
> runtime: convert .s textflags from numbers to symbolic constants.
> Remove NOPROF/DUPOK from everything.
>
> Edits done with a script, except pclinetest.asm which depended
> on the DUPOK flag on main().
>
> Please review this at
https://codereview.appspot.**com/12613044/<https://codereview.appspot.com/126...
>
> Affected files:
>   M src/pkg/debug/gosym/**pclinetest.asm
>   M src/pkg/runtime/memclr_arm.s
>   M src/pkg/runtime/memmove_386.s
>   M src/pkg/runtime/memmove_amd64.**s
>   M src/pkg/runtime/memmove_arm.s
>   M src/pkg/runtime/race_amd64.s
>   M src/pkg/runtime/rt0_darwin_**386.s
>   M src/pkg/runtime/rt0_darwin_**amd64.s
>   M src/pkg/runtime/rt0_freebsd_**386.s
>   M src/pkg/runtime/rt0_freebsd_**amd64.s
>   M src/pkg/runtime/rt0_freebsd_**arm.s
>   M src/pkg/runtime/rt0_linux_386.**s
>   M src/pkg/runtime/rt0_linux_**amd64.s
>   M src/pkg/runtime/rt0_linux_arm.**s
>   M src/pkg/runtime/rt0_netbsd_**386.s
>   M src/pkg/runtime/rt0_netbsd_**amd64.s
>   M src/pkg/runtime/rt0_netbsd_**arm.s
>   M src/pkg/runtime/rt0_openbsd_**386.s
>   M src/pkg/runtime/rt0_openbsd_**amd64.s
>   M src/pkg/runtime/rt0_plan9_386.**s
>   M src/pkg/runtime/rt0_plan9_**amd64.s
>   M src/pkg/runtime/rt0_windows_**386.s
>   M src/pkg/runtime/rt0_windows_**amd64.s
>   M src/pkg/runtime/sys_darwin_**386.s
>   M src/pkg/runtime/sys_darwin_**amd64.s
>   M src/pkg/runtime/sys_freebsd_**386.s
>   M src/pkg/runtime/sys_freebsd_**amd64.s
>   M src/pkg/runtime/sys_freebsd_**arm.s
>   M src/pkg/runtime/sys_linux_386.**s
>   M src/pkg/runtime/sys_linux_**amd64.s
>   M src/pkg/runtime/sys_linux_arm.**s
>   M src/pkg/runtime/sys_netbsd_**386.s
>   M src/pkg/runtime/sys_netbsd_**amd64.s
>   M src/pkg/runtime/sys_netbsd_**arm.s
>   M src/pkg/runtime/sys_openbsd_**386.s
>   M src/pkg/runtime/sys_openbsd_**amd64.s
>   M src/pkg/runtime/sys_plan9_386.**s
>   M src/pkg/runtime/sys_plan9_**amd64.s
>   M src/pkg/runtime/sys_windows_**386.s
>   M src/pkg/runtime/sys_windows_**amd64.s
>   M src/pkg/runtime/vlop_386.s
>   M src/pkg/runtime/vlop_arm.s
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[khr, 2013-08-07 19:20:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=6058f523a441 ***

runtime: convert .s textflags from numbers to symbolic constants.
Remove NOPROF/DUPOK from everything.

Edits done with a script, except pclinetest.asm which depended
on the DUPOK flag on main().

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12613044