Issue 12612043: Authentication fixes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12612043: Authentication fixes.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by frankban

Modified:
10 years, 8 months ago

Reviewers:
benjamin.saller, mp+179014, matthew.scott

Visibility:
Public.

Description

Authentication fixes. Fixed an error in the guiserver authentication when the request id is set to 0. Moved the auth_backend from the app to the handler: it is only relevant in the WebSocketHandler context. Some clean up in the tests. https://code.launchpad.net/~frankban/charms/precise/juju-gui/guiserver-auth-fixes/+merge/179014 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Authentication fixes. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -50 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	server/guiserver/apps.py	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	server/guiserver/auth.py	View	5 chunks	+11 lines, -5 lines	0 comments	Download
M	server/guiserver/handlers.py	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	server/guiserver/tests/test_apps.py	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	server/guiserver/tests/test_auth.py	View	3 chunks	+17 lines, -2 lines	0 comments	Download
M	server/guiserver/tests/test_handlers.py	View	13 chunks	+37 lines, -27 lines	0 comments	Download
M	server/guiserver/tests/test_manage.py	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM The whole 'is not None' things gets us all from time to time. Thanks

10 years, 8 months ago (2013-08-07 23:09:31 UTC) #2

frankban

*** Submitted: Authentication fixes. Fixed an error in the guiserver authentication when the request id ...

10 years, 8 months ago (2013-08-08 08:04:17 UTC) #4

Thank you both for the reviews!

Expand All Messages | Collapse All Messages