Issue 126050043: code review 126050043: cmd/ld: handle large link base addresses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 126050043: code review 126050043: cmd/ld: handle large link base addresses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rsc

Modified:
10 years, 9 months ago

Reviewers:
rminnich, dvyukov

CC:
iant, dvyukov, rminnich, golang-codereviews

Visibility:
Public.

Description

cmd/ld: handle large link base addresses codeblk and datblk were truncating their arguments to int32. Don't do that.

Patch Set 1 #

Patch Set 2 : diff -r 98a99580510924830669129217de838520223bb6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 98a99580510924830669129217de838520223bb6 https://code.google.com/p/go/ #

Patch Set 4 : diff -r d4469d39943e3f47e25a3d30b00a3947472c4fa5 https://code.google.com/p/go/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	src/cmd/ld/data.c	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
	M	src/cmd/ld/lib.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-codereviews@googlegroups.com, rminnich@gmail.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 9 months ago (2014-08-12 21:08:47 UTC) #1

rsc

10 years, 9 months ago (2014-08-12 21:41:20 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=59b2d432eeca ***

cmd/ld: handle large link base addresses

codeblk and datblk were truncating their
arguments to int32. Don't do that.

LGTM=dvyukov, rminnich
R=iant, dvyukov, rminnich
CC=golang-codereviews
https://codereview.appspot.com/126050043

Expand All Messages | Collapse All Messages