Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(179)

Issue 12603049: code review 12603049: bufio: drop Writer and Reset buffer recycling, add Rese... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by bradfitz
Modified:
4 years, 3 months ago
Reviewers:
rsc
CC:
golang-dev, peted, r, rsc
Visibility:
Public.

Description

bufio: drop buffer recycling, add Reader.Reset and Writer.Reset Fixes issue 6086

Patch Set 1 #

Patch Set 2 : diff -r d70c9a6579ca https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d70c9a6579ca https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 4f468b088d66 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -106 lines) Patch
M src/pkg/bufio/bufio.go View 1 2 3 19 chunks +39 lines, -106 lines 0 comments Download
M src/pkg/bufio/bufio_test.go View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 6
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
4 years, 3 months ago (2013-08-09 23:40:50 UTC) #1
peted
On 2013/08/09 23:40:50, bradfitz wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
4 years, 3 months ago (2013-08-09 23:55:27 UTC) #2
r
The plan is not to clutter the CLs but to update the doc in a ...
4 years, 3 months ago (2013-08-09 23:56:32 UTC) #3
peted
On 2013/08/09 23:56:32, r wrote: > The plan is not to clutter the CLs but ...
4 years, 3 months ago (2013-08-10 00:00:47 UTC) #4
rsc
LGTM Thanks. https://codereview.appspot.com/12603049/diff/5001/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): https://codereview.appspot.com/12603049/diff/5001/src/pkg/bufio/bufio.go#newcode249 src/pkg/bufio/bufio.go:249: // The bytes stop being valid at ...
4 years, 3 months ago (2013-08-10 02:35:28 UTC) #5
bradfitz
4 years, 3 months ago (2013-08-11 02:22:15 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=b302ea285b42 ***

bufio: drop buffer recycling, add Reader.Reset and Writer.Reset

Fixes issue 6086

R=golang-dev, pieter, r, rsc
CC=golang-dev
https://codereview.appspot.com/12603049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4