Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207)

Issue 12602044: Add launchpad icons to unit list

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by jeff.pihach
Modified:
11 years, 2 months ago
Reviewers:
mp+179002, benji
Visibility:
Public.

Description

Add launchpad icons to unit list Landing Ant's branch adding the landscape icons to the unit lists in the new inspector and fixing the width of the inspector to avoid scrollbars in some browsers. https://code.launchpad.net/~hatch/juju-gui/inspector-icons/+merge/179002 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add launchpad icons to unit list #

Patch Set 3 : Add launchpad icons to unit list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/inspector-charm-landscape.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M lib/views/juju-inspector.less View 5 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 3
jeff.pihach
Please take a look.
11 years, 2 months ago (2013-08-07 15:11:49 UTC) #1
benji
LGTM
11 years, 2 months ago (2013-08-07 15:14:39 UTC) #2
jeff.pihach
11 years, 2 months ago (2013-08-07 15:38:45 UTC) #3
*** Submitted:

Add launchpad icons to unit list

Landing Ant's branch adding the landscape icons to
the unit lists in the new inspector and fixing the
width of the inspector to avoid scrollbars in some
browsers.

R=benji
CC=
https://codereview.appspot.com/12602044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b