Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 1258041: PEP 3318 - New struct string syntax

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by minge
Modified:
7 years, 1 month ago
Reviewers:
dickinsm
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Description

This patch implements parts of the new struct string syntax from PEP 3118. More specifically, the 'T{}' syntax and the ability to place byte-order specifiers ('<', '>', '@', '^', '!", '=') anywhere in the struct string.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+620 lines, -90 lines) Patch
Doc/library/struct.rst View 4 chunks +55 lines, -8 lines 0 comments Download
Lib/test/test_struct.py View 2 chunks +101 lines, -0 lines 0 comments Download
Modules/_struct.c View 21 chunks +464 lines, -82 lines 2 comments Download

Messages

Total messages: 2
minge
11 years, 5 months ago (2010-05-18 12:18:21 UTC) #1
minge
11 years, 5 months ago (2010-05-20 13:58:04 UTC) #2
http://codereview.appspot.com/1258041/diff/1/4
File Modules/_struct.c (right):

http://codereview.appspot.com/1258041/diff/1/4#newcode1730
Modules/_struct.c:1730: assert(soself->s_codes != NULL);
This should be 'assert(soself->s_tree->s_codes != NULL)'.

http://codereview.appspot.com/1258041/diff/1/4#newcode1765
Modules/_struct.c:1765: assert(soself->s_codes != NULL);
This should be 'assert(soself->s_tree->s_codes != NULL)'.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b