code review 12580044: test: fix return.go to remove unused labels

test: fix return.go to remove unused labels

The gc compiler only gives an error about an unused label if
it has not given any errors in an earlier pass.  Remove all
unused labels in this test because they don't test anything
useful and they cause gccgo to give unexpected errors.

[iant, 2013-08-07 18:12:59]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-08-07 18:14:33]

LGTM



On Wed, Aug 7, 2013 at 11:12 AM, <iant@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> test: fix return.go to remove unused labels
>
> The gc compiler only gives an error about an unused label if
> it has not given any errors in an earlier pass.  Remove all
> unused labels in this test because they don't test anything
> useful and they cause gccgo to give unexpected errors.
>
> Please review this at
https://codereview.appspot.**com/12580044/<https://codereview.appspot.com/125...
>
> Affected files:
>   M test/return.go
>
>
> Index: test/return.go
> ==============================**==============================**=======
> --- a/test/return.go
> +++ b/test/return.go
> @@ -272,7 +272,6 @@
>  } // ERROR "missing return"
>
>  func _() int {
> -L:
>         print(1)
>         if x == nil {
>                 panic(2)
> @@ -972,7 +971,6 @@
>  } // ERROR "missing return"
>
>  func _() int {
> -L:
>         if x == nil {
>                 panic(2)
>         } else if x == 1 {
> @@ -1666,7 +1664,6 @@
>  } // ERROR "missing return"
>
>  var _ = func() int {
> -L:
>         print(1)
>         if x == nil {
>                 panic(2)
> @@ -2366,7 +2363,6 @@
>  } // ERROR "missing return"
>
>  var _ = func() int {
> -L:
>         if x == nil {
>                 panic(2)
>         } else if x == 1 {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[iant, 2013-08-07 18:19:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=d5bc54fe16de ***

test: fix return.go to remove unused labels

The gc compiler only gives an error about an unused label if
it has not given any errors in an earlier pass.  Remove all
unused labels in this test because they don't test anything
useful and they cause gccgo to give unexpected errors.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12580044