Adds unit action button functionality

Adds unit action button functionality

Displays the appropriate action buttons for each unit
category.

Adds the boiler plate for the replace functionality but
this will not be implemented until we have minimum
units set up.

https://code.launchpad.net/~hatch/juju-gui/unit-rrr/+merge/178857

(do not edit description out of merge proposal)

[jeff.pihach, 2013-08-06 21:35:52]

Please take a look.

[benjamin.saller, 2013-08-06 21:48:06]

LGTM

w/o QA, If you need that let me know.

Thanks for this.

https://codereview.appspot.com/12567043/diff/1/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/12567043/diff/1/app/views/inspector.js#newcode877
app/views/inspector.js:877: handlers[e.currentTarget.getData('type')](unitNames,
env);
I'd recommend that you check that handler resolved to something prior to
invoking it. Its possible for the template to become out of sync.

https://codereview.appspot.com/12567043/diff/1/app/views/inspector.js#newcode891
app/views/inspector.js:891: env.resolved(unitName, null);
We should note that the API to do this style of interaction should also take an
id list, at scale, this is going to take quite some time just to fire off all
the RPC and it will hang the UI.

https://codereview.appspot.com/12567043/diff/1/app/views/inspector.js#newcode...
app/views/inspector.js:1062: generateActionButtonList(d.category));
nice

[jeff.pihach, 2013-08-06 21:59:23]

Thanks for the review! Comments within and changes coming soon.

https://codereview.appspot.com/12567043/diff/1/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/12567043/diff/1/app/views/inspector.js#newcode877
app/views/inspector.js:877: handlers[e.currentTarget.getData('type')](unitNames,
env);
Good idea.

https://codereview.appspot.com/12567043/diff/1/app/views/inspector.js#newcode891
app/views/inspector.js:891: env.resolved(unitName, null);
Yeah that's true I'll create a ticket to add this list functionality.

https://codereview.appspot.com/12567043/diff/1/app/views/inspector.js#newcode...
app/views/inspector.js:1062: generateActionButtonList(d.category));
Thanks

[jeff.pihach, 2013-08-06 22:09:23]

Please take a look.

[matthew.scott, 2013-08-07 16:05:04]

LGTM with QA.  Thanks!

https://codereview.appspot.com/12567043/diff/4002/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/12567043/diff/4002/app/views/inspector.js#newc...
app/views/inspector.js:925: // currently a noop until min units is setup
Call out with TODO

[jeff.pihach, 2013-08-07 16:23:41]

*** Submitted:

Adds unit action button functionality

Displays the appropriate action buttons for each unit
category.

Adds the boiler plate for the replace functionality but
this will not be implemented until we have minimum
units set up.

R=benjamin.saller, matthew.scott
CC=
https://codereview.appspot.com/12567043