Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(174)

Issue 12566046: code review 12566046: cmd/go: add -t flag to 'go get' to download test depend... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by adg
Modified:
4 years, 3 months ago
Reviewers:
rsc
CC:
golang-dev, dsymonds, bradfitz, r, rsc, rog
Visibility:
Public.

Description

cmd/go: add -t flag to 'go get' to download test dependencies Fixes issue 5126.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r d7db8c804ffa https://code.google.com/p/go #

Patch Set 3 : diff -r 2bf4cf823da3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M src/cmd/go/doc.go View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/cmd/go/get.go View 1 6 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 19
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
4 years, 3 months ago (2013-08-11 22:15:42 UTC) #1
dsymonds
Maybe test dependencies should always be downloaded. Downloading a bit extra isn't a big deal, ...
4 years, 3 months ago (2013-08-11 22:35:56 UTC) #2
adg
I thought that, too. Maybe there should be a flag to *not* download test dependencies? ...
4 years, 3 months ago (2013-08-11 22:49:56 UTC) #3
bradfitz
Call it -nomock On Aug 11, 2013 3:49 PM, "Andrew Gerrand" <adg@golang.org> wrote: > I ...
4 years, 3 months ago (2013-08-11 22:50:40 UTC) #4
dsymonds
I think it's a pretty rare case that a test dependency is large enough to ...
4 years, 3 months ago (2013-08-11 23:16:37 UTC) #5
r
I would favor opt-in not opt-out. -rob
4 years, 3 months ago (2013-08-12 00:11:08 UTC) #6
adg
On 12 August 2013 10:10, Rob Pike <r@golang.org> wrote: > I would favor opt-in not ...
4 years, 3 months ago (2013-08-12 00:20:37 UTC) #7
dsymonds
On 12 August 2013 10:10, Rob Pike <r@golang.org> wrote: > I would favor opt-in not ...
4 years, 3 months ago (2013-08-12 00:20:45 UTC) #8
r
Opt-in to download test dependencies. -rob
4 years, 3 months ago (2013-08-12 01:05:40 UTC) #9
rsc
let's start as conservatively as possible: test dependencies should be ignored by default. -t should ...
4 years, 3 months ago (2013-08-12 01:13:05 UTC) #10
adg
On 12 August 2013 11:13, Russ Cox <rsc@golang.org> wrote: > test dependencies should be ignored ...
4 years, 3 months ago (2013-08-12 01:22:59 UTC) #11
rog
Thanks for this - I've wanted it for some time. I'm happy with the proposed ...
4 years, 3 months ago (2013-08-12 08:18:39 UTC) #12
rog
On a slightly related not, the only thing I really miss currently is the ability ...
4 years, 3 months ago (2013-08-12 08:23:19 UTC) #13
adg
go test -run=XXX -v ./... ?
4 years, 3 months ago (2013-08-12 09:28:52 UTC) #14
rog
On 12 August 2013 10:28, Andrew Gerrand <adg@golang.org> wrote: > go test -run=XXX -v ./... ...
4 years, 3 months ago (2013-08-12 09:36:56 UTC) #15
r
https://codereview.appspot.com/12566046/diff/1/src/cmd/go/doc.go File src/cmd/go/doc.go (right): https://codereview.appspot.com/12566046/diff/1/src/cmd/go/doc.go#newcode251 src/cmd/go/doc.go:251: the tests for the specified packages. also? or only?
4 years, 3 months ago (2013-08-13 04:40:48 UTC) #16
adg
https://codereview.appspot.com/12566046/diff/1/src/cmd/go/doc.go File src/cmd/go/doc.go (right): https://codereview.appspot.com/12566046/diff/1/src/cmd/go/doc.go#newcode251 src/cmd/go/doc.go:251: the tests for the specified packages. On 2013/08/13 04:40:49, ...
4 years, 3 months ago (2013-08-13 05:24:40 UTC) #17
rsc
LGTM
4 years, 3 months ago (2013-08-13 20:20:09 UTC) #18
adg
4 years, 3 months ago (2013-08-14 01:01:28 UTC) #19
*** Submitted as https://code.google.com/p/go/source/detail?r=9f6a7e4c3f62 ***

cmd/go: add -t flag to 'go get' to download test dependencies

Fixes issue 5126.

R=golang-dev, dsymonds, bradfitz, r, rsc, rogpeppe
CC=golang-dev
https://codereview.appspot.com/12566046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4