code review 12566046: cmd/go: add -t flag to 'go get' to download test depend...

cmd/go: add -t flag to 'go get' to download test dependencies

Fixes issue 5126.

[adg, 2013-08-11 22:15:42]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2013-08-11 22:35:56]

Maybe test dependencies should always be downloaded. Downloading a bit
extra isn't a big deal, but missing deps later (e.g. getting on a plane)
can be mighty annoying.

[adg, 2013-08-11 22:49:56]

I thought that, too. Maybe there should be a flag to *not* download test
dependencies? I can see situations where that may be undesired. ("Damn it,
I don't want gomock!")




On 12 August 2013 08:35, David Symonds <dsymonds@golang.org> wrote:

> Maybe test dependencies should always be downloaded. Downloading a bit
> extra isn't a big deal, but missing deps later (e.g. getting on a plane)
> can be mighty annoying.
>

[bradfitz, 2013-08-11 22:50:40]

Call it -nomock
 On Aug 11, 2013 3:49 PM, "Andrew Gerrand" <adg@golang.org> wrote:

> I thought that, too. Maybe there should be a flag to *not* download test
> dependencies? I can see situations where that may be undesired. ("Damn it,
> I don't want gomock!")
>
>
>
>
> On 12 August 2013 08:35, David Symonds <dsymonds@golang.org> wrote:
>
>> Maybe test dependencies should always be downloaded. Downloading a bit
>> extra isn't a big deal, but missing deps later (e.g. getting on a plane)
>> can be mighty annoying.
>>
>
>  --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

[dsymonds, 2013-08-11 23:16:37]

I think it's a pretty rare case that a test dependency is large enough
to want to avoid even downloading, but I wouldn't object to a flag to
opt-out.

[r, 2013-08-12 00:11:08]

I would favor opt-in not opt-out.

-rob

[adg, 2013-08-12 00:20:37]

On 12 August 2013 10:10, Rob Pike <r@golang.org> wrote:

> I would favor opt-in not opt-out.


I too favor opt-in, hence this CL.

Probably more interesting aspects of this CL to discuss:
- should the test dependencies be fetched for the named packages only? Or
should test dependencies be fetched for all packages in the dependency tree
(test or non-test)? Ie, should I be able to say "go get -t foo" and have
"go test ..." always work?
- should the test dependencies be installed? This CL merely downloads them,
regardless of whether -d is provided.

[dsymonds, 2013-08-12 00:20:45]

On 12 August 2013 10:10, Rob Pike <r@golang.org> wrote:

> I would favor opt-in not opt-out.

Opt-in to downloading test dependencies, or opt-in to not downloading
test dependencies?

[r, 2013-08-12 01:05:40]

Opt-in to download test dependencies.

-rob

[rsc, 2013-08-12 01:13:05]

let's start as conservatively as possible:

test dependencies should be ignored by default.
-t should download but not install test dependencies.
-t should download test dependencies for only the named package,
  not the things it depends on.

the goal is that go get -t foo does the minimum amount necessary to make
'go test foo' run a test.

[adg, 2013-08-12 01:22:59]

On 12 August 2013 11:13, Russ Cox <rsc@golang.org> wrote:

> test dependencies should be ignored by default.
> -t should download but not install test dependencies.
> -t should download test dependencies for only the named package,
>   not the things it depends on.
>

OK, I agree. This is what this CL does.

[rog, 2013-08-12 08:18:39]

Thanks for this - I've wanted it for some time.
I'm happy with the proposed semantics.

On 12 August 2013 02:22, Andrew Gerrand <adg@golang.org> wrote:
>
> On 12 August 2013 11:13, Russ Cox <rsc@golang.org> wrote:
>>
>> test dependencies should be ignored by default.
>> -t should download but not install test dependencies.
>> -t should download test dependencies for only the named package,
>>   not the things it depends on.
>
>
> OK, I agree. This is what this CL does.
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[rog, 2013-08-12 08:23:19]

On a slightly related not, the only thing I really miss
currently is the ability to quickly check if all code (including tests)
compiles after a change, without running tests.

Our tests take quite a while to run and it's really
useful to check that all the code at least type checks
correctly before running them.



On 12 August 2013 09:18, roger peppe <rogpeppe@gmail.com> wrote:
> Thanks for this - I've wanted it for some time.
> I'm happy with the proposed semantics.
>
> On 12 August 2013 02:22, Andrew Gerrand <adg@golang.org> wrote:
>>
>> On 12 August 2013 11:13, Russ Cox <rsc@golang.org> wrote:
>>>
>>> test dependencies should be ignored by default.
>>> -t should download but not install test dependencies.
>>> -t should download test dependencies for only the named package,
>>>   not the things it depends on.
>>
>>
>> OK, I agree. This is what this CL does.
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>

[adg, 2013-08-12 09:28:52]

go test -run=XXX -v ./...

?

[rog, 2013-08-12 09:36:56]

On 12 August 2013 10:28, Andrew Gerrand <adg@golang.org> wrote:
> go test -run=XXX -v ./...

I can't believe I didn't think of that.

[r, 2013-08-13 04:40:48]

https://codereview.appspot.com/12566046/diff/1/src/cmd/go/doc.go
File src/cmd/go/doc.go (right):

https://codereview.appspot.com/12566046/diff/1/src/cmd/go/doc.go#newcode251
src/cmd/go/doc.go:251: the tests for the specified packages.
also? or only?

[adg, 2013-08-13 05:24:40]

https://codereview.appspot.com/12566046/diff/1/src/cmd/go/doc.go
File src/cmd/go/doc.go (right):

https://codereview.appspot.com/12566046/diff/1/src/cmd/go/doc.go#newcode251
src/cmd/go/doc.go:251: the tests for the specified packages.
On 2013/08/13 04:40:49, r wrote:
> also? or only?

also

[rsc, 2013-08-13 20:20:09]

LGTM

[adg, 2013-08-14 01:01:28]

*** Submitted as https://code.google.com/p/go/source/detail?r=9f6a7e4c3f62 ***

cmd/go: add -t flag to 'go get' to download test dependencies

Fixes issue 5126.

R=golang-dev, dsymonds, bradfitz, r, rsc, rogpeppe
CC=golang-dev
https://codereview.appspot.com/12566046