Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1512)

Issue 12566043: Issue 369: Change default behavior of an HTTP request (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by peleyal
Modified:
6 years, 1 month ago
Reviewers:
ngmiceli
CC:
google-api-dotnet-client_googlegroups.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 369: Change default behavior of Http request

Patch Set 1 #

Patch Set 2 : minor #

Total comments: 8

Patch Set 3 : Miceli review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -64 lines) Patch
M Src/GoogleApis.Tests/Apis/Http/ConfigurableMessageHandlerTest.cs View 1 2 9 chunks +23 lines, -12 lines 0 comments Download
M Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs View 1 2 5 chunks +16 lines, -20 lines 0 comments Download
M Src/GoogleApis.Tests/Apis/Services/BaseClientServiceTest.cs View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M Src/GoogleApis.Tests/Apis/Utils/ExponentialBackOffTest.cs View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Src/GoogleApis/Apis/Authentication/DelegateAuthenticator.cs View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Src/GoogleApis/Apis/Http/BackOffHandler.cs View 4 chunks +5 lines, -5 lines 0 comments Download
M Src/GoogleApis/Apis/Http/ConfigurableMessageHandler.cs View 2 chunks +4 lines, -4 lines 0 comments Download
M Src/GoogleApis/Apis/Services/BaseClientService.cs View 1 2 6 chunks +9 lines, -12 lines 0 comments Download
M Src/GoogleApis/Apis/[Media]/Download/MediaDownloader.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
peleyal
Hi Nick, I worked on changing the default behavior of an HTTP request. Num of ...
6 years, 1 month ago (2013-08-06 21:42:57 UTC) #1
peleyal
ping Nicolas :)
6 years, 1 month ago (2013-08-12 13:07:59 UTC) #2
ngmiceli
What's the client library's current default behavior for backoff? Is it enabled or disabled? The ...
6 years, 1 month ago (2013-08-13 19:31:26 UTC) #3
ngmiceli
Also, I get a patch failure on BaseClientService against head. Do you need to merge ...
6 years, 1 month ago (2013-08-13 19:36:25 UTC) #4
peleyal
The default behavior is to have 3 tries maximum (when exponential back-off is enable by ...
6 years, 1 month ago (2013-08-13 21:46:19 UTC) #5
ngmiceli
6 years, 1 month ago (2013-08-16 20:26:41 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b