Issue 12563043: code review 12563043: runtime: don't mark the new call trampolines as NOSPLIT.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12563043: code review 12563043: runtime: don't mark the new call trampolines as NOSPLIT. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by khr

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: don't mark the new call trampolines as NOSPLIT. They may call other NOSPLIT routines, and that might overflow the stack.

Patch Set 1 #

Patch Set 2 : diff -r 51d2970d9348 https://khr%40golang.org@code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -87 lines)			Patch
M	src/pkg/runtime/asm_386.s	View	2 chunks	+29 lines, -29 lines	0 comments	Download
M	src/pkg/runtime/asm_amd64.s	View	2 chunks	+29 lines, -29 lines	0 comments	Download
M	src/pkg/runtime/asm_arm.s	View	2 chunks	+29 lines, -29 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

khr

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

11 years, 7 months ago (2013-08-06 20:15:10 UTC) #1

khr

11 years, 7 months ago (2013-08-06 21:33:58 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=1cffbb7333ec ***

runtime: don't mark the new call trampolines as NOSPLIT.
They may call other NOSPLIT routines, and that might
overflow the stack.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12563043

Expand All Messages | Collapse All Messages