Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 8 months ago
(2014-08-20 14:58:19 UTC)
#1
10 years, 8 months ago
(2014-08-20 18:01:18 UTC)
#2
On 2014/08/20 14:58:19, dvyukov wrote:
> Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org,
mailto:rlh@golang.org,
> mailto:rsc@golang.org),
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
Looks fine, but could you implement the _go versions in Go?
On 2014/08/20 18:01:18, khr wrote: > On 2014/08/20 14:58:19, dvyukov wrote: > > Hello mailto:golang-codereviews@googlegroups.com ...
10 years, 8 months ago
(2014-08-21 08:52:21 UTC)
#3
On 2014/08/20 18:01:18, khr wrote:
> On 2014/08/20 14:58:19, dvyukov wrote:
> > Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org,
> mailto:rlh@golang.org,
> > mailto:rsc@golang.org),
> >
> > I'd like you to review this change to
> > https://dvyukov%40google.com@code.google.com/p/go/
>
> Looks fine, but could you implement the _go versions in Go?
as you wish
PTAL
Issue 125610043: code review 125610043: runtime: convert lfstack to Go
(Closed)
Created 10 years, 8 months ago by dvyukov
Modified 10 years, 8 months ago
Reviewers:
Base URL:
Comments: 0