Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(697)

Issue 125610043: code review 125610043: runtime: convert lfstack to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dvyukov
Modified:
10 years, 8 months ago
Reviewers:
khr
CC:
golang-codereviews, khr, rlh, rsc
Visibility:
Public.

Description

runtime: convert lfstack to Go It is called from Go only in tests.

Patch Set 1 #

Patch Set 2 : diff -r 9985ecf9828f87d8887550109060357e2163ab8a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 9985ecf9828f87d8887550109060357e2163ab8a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 8f877ce632b3de0009504d6f1b24b8deb741f15a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 8f877ce632b3de0009504d6f1b24b8deb741f15a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 8f877ce632b3de0009504d6f1b24b8deb741f15a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r 8f877ce632b3de0009504d6f1b24b8deb741f15a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r 8f877ce632b3de0009504d6f1b24b8deb741f15a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 9 : diff -r 5efda2acf6471079841ad0cb73b3ed7aeba1183e https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M src/pkg/runtime/export_test.go View 1 2 3 2 chunks +23 lines, -4 lines 0 comments Download
M src/pkg/runtime/lfstack.c View 1 2 3 4 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 8 months ago (2014-08-20 14:58:19 UTC) #1
khr
On 2014/08/20 14:58:19, dvyukov wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org, mailto:rlh@golang.org, > mailto:rsc@golang.org), > > ...
10 years, 8 months ago (2014-08-20 18:01:18 UTC) #2
dvyukov
On 2014/08/20 18:01:18, khr wrote: > On 2014/08/20 14:58:19, dvyukov wrote: > > Hello mailto:golang-codereviews@googlegroups.com ...
10 years, 8 months ago (2014-08-21 08:52:21 UTC) #3
khr
LGTM
10 years, 8 months ago (2014-08-21 16:34:45 UTC) #4
dvyukov
10 years, 8 months ago (2014-08-21 17:10:50 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=c9b3a9a13664 ***

runtime: convert lfstack to Go
It is called from Go only in tests.

LGTM=khr
R=golang-codereviews, khr
CC=golang-codereviews, rlh, rsc
https://codereview.appspot.com/125610043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b