LGTM On Aug 6, 2013 3:58 PM, <r@golang.org> wrote: > Reviewers: golang-dev1, > > Message: ...
11 years, 10 months ago
(2013-08-06 23:33:02 UTC)
#2
LGTM
On Aug 6, 2013 3:58 PM, <r@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> all: fix up language in a couple of comments
> Leftovers from 11699043
>
> Please review this at
https://codereview.appspot.**com/12558046/<https://codereview.appspot.com/125...
>
> Affected files:
> M src/pkg/go/ast/ast.go
> M src/pkg/html/template/css.go
>
>
> Index: src/pkg/go/ast/ast.go
> ==============================**==============================**=======
> --- a/src/pkg/go/ast/ast.go
> +++ b/src/pkg/go/ast/ast.go
> @@ -528,7 +528,7 @@
> }
>
> // IsExported reports whether id is an exported Go symbol
> -// (i.e., whether it begins with an uppercase letter).
> +// (that is, whether it begins with an uppercase letter).
> //
> func (id *Ident) IsExported() bool { return IsExported(id.Name) }
>
> Index: src/pkg/html/template/css.go
> ==============================**==============================**=======
> --- a/src/pkg/html/template/css.go
> +++ b/src/pkg/html/template/css.go
> @@ -99,7 +99,7 @@
> return b
> }
>
> -// isHex reports reports whether the given character is a hex digit.
> +// isHex reports whether the given character is a hex digit.
> func isHex(c byte) bool {
> return '0' <= c && c <= '9' || 'a' <= c && c <= 'f' || 'A' <= c &&
> c <= 'F'
> }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>
Issue 12558046: code review 12558046: all: fix up language in a couple of comments
(Closed)
Created 11 years, 10 months ago by r
Modified 11 years, 10 months ago
Reviewers:
Base URL:
Comments: 0