Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(427)

Issue 12557045: add some missing css support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by felix8a
Modified:
12 years, 8 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL - defines and allows box-sizing, overflow-wrap, word-wrap. - fixes some of the background property defs. - adds 'vmin' and 'vmax' to the units list. There's a systematic problem with 'inherit' in our css-defs. A lot of the css spec docs omit 'inherit' in describing individual properties but have a statement like "All properties defined in this specification also accept the inherit keyword as their value, but for readability it has not been listed explicitly." I've added a few of the missing inherits in this CL, but I haven't yet tried to systematically add all the missing inherits. I suspect it might be simpler to implicitly allow all properties to have the value 'inherit', but I need to verify that's correct and/or safe.

Patch Set 1 #

Total comments: 17

Patch Set 2 : add some missing css support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -37 lines) Patch
src/com/google/caja/lang/css/css-extensions-defs.json View 1 19 chunks +62 lines, -36 lines 0 comments Download
src/com/google/caja/lang/css/css-extensions-whitelist.json View 3 chunks +3 lines, -0 lines 0 comments Download
tests/com/google/caja/lang/css/CssPropertyPatternsTest.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
felix8a
12 years, 8 months ago (2013-08-07 16:58:55 UTC) #1
MikeSamuel
https://codereview.appspot.com/12557045/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json File src/com/google/caja/lang/css/css-extensions-defs.json (right): https://codereview.appspot.com/12557045/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode145 src/com/google/caja/lang/css/css-extensions-defs.json:145: "signature": "<box> [, <box>]* | inherit", "Inherit" is subsumed ...
12 years, 8 months ago (2013-08-07 17:55:46 UTC) #2
felix8a
This CL - defines and allows box-sizing, overflow-wrap, word-wrap. - fixes some of the background ...
12 years, 8 months ago (2013-08-07 20:03:08 UTC) #3
felix8a
new snapshot https://codereview.appspot.com/12557045/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json File src/com/google/caja/lang/css/css-extensions-defs.json (right): https://codereview.appspot.com/12557045/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode150 src/com/google/caja/lang/css/css-extensions-defs.json:150: "source": "http://www.w3.org/TR/2009/CR-css3-background-20091217/#the-background-clip", On 2013/08/07 17:55:46, MikeSamuel wrote: ...
12 years, 8 months ago (2013-08-07 20:03:15 UTC) #4
MikeSamuel
LGTM
12 years, 8 months ago (2013-08-07 22:38:26 UTC) #5
felix8a
12 years, 8 months ago (2013-08-08 19:10:51 UTC) #6
@r5537
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b