Removes autocomplete feature flag, updates design

Removes autocomplete feature flag, updates design

- Updates the CSS to more closely match the UX visual:
https://drive.google.com/a/canonical.com/?pli=1#folders/0B7XG_QBXNwY1ZmdTTDdTZEdFOGM

Addresses notes from initial UX feedback, see the following:
- Spacing, font size, and horizontal lines need to be adjusted.
- Particularly notice the darker line between categories and charms
(search for "ap" to see what I mean).
- Please remove the "recommended" star.  All autocomplete charm results
are recommended, so it is unnecessary.

This required adjusting how the results were rendered and we add additional
css classes on the tokens displayed to help the css find the last category
result (for the longer bolder line), and for telling categories from charms.

Tests were refactored to place heavier functional tests in their own suite so
that they could have standardized setup/teardown that was more costly than
most of the basic tests. Also added tests for the css generation mentioned
above.

Please QA: instructions

- Load the sidebar, search for a result. The best current example is 'a' as
that pulls in two categories and several results. Check for the design spacing
and borders. Note that the last result will not have a border on the bottom.
- Try the same in fullscreen
- Search, click, search some more. Anything that doesn't behave or look
correct please bring up. This removes the feature flag and provides
autocomplete to all users ootb.

https://code.launchpad.net/~rharding/juju-gui/ac4/+merge/179440

(do not edit description out of merge proposal)

[rharding, 2013-08-09 13:41:35]

Please take a look.

[j.c.sackett, 2013-08-09 14:05:42]

LGTM. \o/ This looks good!

Code wise, minor comments below.

QA is ok, with the following observations (I don't think these are your branch's
fault)

1. The sorting on autocomplete is odd: apache2-passenger above apache2 when
"apach" is entered. We discussed this on IRC and agree it's on the charmworld
side.

2. Charm details page is once again loading slightly scrolled down from both
search results and an AC selection. This only occurs in fullscreen, and is non
blocking IMO.

https://codereview.appspot.com/12545044/diff/1/app/widgets/charm-search.js
File app/widgets/charm-search.js (right):

https://codereview.appspot.com/12545044/diff/1/app/widgets/charm-search.js#ne...
app/widgets/charm-search.js:220: var lastIdx = idx - 1;
Deryck would be so sad...

https://codereview.appspot.com/12545044/diff/1/app/widgets/charm-search.js#ne...
app/widgets/charm-search.js:223: res[lastIdx] = lastHtml;
Can you not just do `res[lastIdx].addClass(...)`?

[rharding, 2013-08-09 14:36:04]

Please take a look.

[benjamin.saller, 2013-08-09 17:08:43]

Code LGTM, thanks

[rharding, 2013-08-12 19:06:53]

*** Submitted:

Removes autocomplete feature flag, updates design

- Updates the CSS to more closely match the UX visual:
https://drive.google.com/a/canonical.com/?pli=1#folders/0B7XG_QBXNwY1ZmdTTDdT...

Addresses notes from initial UX feedback, see the following:
- Spacing, font size, and horizontal lines need to be adjusted.
- Particularly notice the darker line between categories and charms
(search for "ap" to see what I mean).
- Please remove the "recommended" star.  All autocomplete charm results
are recommended, so it is unnecessary.

This required adjusting how the results were rendered and we add additional
css classes on the tokens displayed to help the css find the last category
result (for the longer bolder line), and for telling categories from charms.

Tests were refactored to place heavier functional tests in their own suite so
that they could have standardized setup/teardown that was more costly than
most of the basic tests. Also added tests for the css generation mentioned
above.

Please QA: instructions

- Load the sidebar, search for a result. The best current example is 'a' as
that pulls in two categories and several results. Check for the design spacing
and borders. Note that the last result will not have a border on the bottom.
- Try the same in fullscreen
- Search, click, search some more. Anything that doesn't behave or look
correct please bring up. This removes the feature flag and provides
autocomplete to all users ootb.

R=j.c.sackett, benjamin.saller
CC=
https://codereview.appspot.com/12545044