Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(164)

Issue 12544043: runtime: chans on steroids

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by dvyukov
Modified:
5 months, 1 week ago
Reviewers:
Visibility:
Public.

Description

runtime: new lock-free chans benchmark old ns/op new ns/op delta BenchmarkSelectUncontended 232 153 -34.05% BenchmarkSelectUncontended-2 125 88 -29.12% BenchmarkSelectUncontended-4 87 50 -42.53% BenchmarkSelectUncontended-8 57 40 -28.97% BenchmarkSelectContended 228 146 -35.96% BenchmarkSelectContended-2 520 270 -48.08% BenchmarkSelectContended-4 591 342 -42.13% BenchmarkSelectContended-8 641 263 -58.97% BenchmarkSelectNonblock 94 39 -58.22% BenchmarkSelectNonblock-2 47 20 -57.05% BenchmarkSelectNonblock-4 28 10 -62.63% BenchmarkSelectNonblock-8 20 8 -58.68% BenchmarkChanUncontended 59 38 -34.18% BenchmarkChanUncontended-2 29 19 -34.35% BenchmarkChanUncontended-4 16 10 -40.24% BenchmarkChanUncontended-8 12 8 -34.17% BenchmarkChanContended 59 39 -33.45% BenchmarkChanContended-2 295 114 -61.36% BenchmarkChanContended-4 311 354 +13.83% BenchmarkChanContended-8 311 570 +83.28% BenchmarkChanSync 136 136 +0.00% BenchmarkChanSync-2 470 457 -2.77% BenchmarkChanSync-4 403 399 -0.99% BenchmarkChanSync-8 352 368 +4.55% BenchmarkChanProdCons0 139 143 +2.88% BenchmarkChanProdCons0-2 264 321 +21.59% BenchmarkChanProdCons0-4 352 418 +18.75% BenchmarkChanProdCons0-8 622 794 +27.65% BenchmarkChanProdCons10 82 74 -10.02% BenchmarkChanProdCons10-2 275 392 +42.55% BenchmarkChanProdCons10-4 571 484 -15.24% BenchmarkChanProdCons10-8 759 587 -22.66% BenchmarkChanProdCons100 61 42 -31.38% BenchmarkChanProdCons100-2 195 92 -52.67% BenchmarkChanProdCons100-4 377 152 -59.68% BenchmarkChanProdCons100-8 388 391 +0.77% BenchmarkChanProdConsWork0 659 674 +2.28% BenchmarkChanProdConsWork0-2 404 493 +22.03% BenchmarkChanProdConsWork0-4 633 573 -9.48% BenchmarkChanProdConsWork0-8 653 848 +29.86% BenchmarkChanProdConsWork10 615 601 -2.28% BenchmarkChanProdConsWork10-2 469 438 -6.61% BenchmarkChanProdConsWork10-4 799 278 -65.21% BenchmarkChanProdConsWork10-8 955 446 -53.30% BenchmarkChanProdConsWork100 593 579 -2.36% BenchmarkChanProdConsWork100-2 459 415 -9.59% BenchmarkChanProdConsWork100-4 732 369 -49.59% BenchmarkChanProdConsWork100-8 755 384 -49.14% BenchmarkChanCreation 161 120 -25.47% BenchmarkChanCreation-2 142 113 -20.42% BenchmarkChanCreation-4 103 104 +0.97% BenchmarkChanCreation-8 106 91 -13.96% BenchmarkChanSem 54 35 -33.83% BenchmarkChanSem-2 53 35 -33.90% BenchmarkChanSem-4 54 35 -34.75% BenchmarkChanSem-8 54 35 -34.75%

Patch Set 1 #

Patch Set 2 : diff -r c224c549a3c7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 1c86edd196bd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 1c86edd196bd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 9d0f388bbe40 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 9d0f388bbe40 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r 9d0f388bbe40 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r 9d0f388bbe40 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 9 : diff -r 9d0f388bbe40 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 10 : diff -r 370d93bf9234 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 11 : diff -r 370d93bf9234 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 12 : diff -r b12d73776439 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 13 : diff -r 65a1b6a436af https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 14 : diff -r 2ca683523bf0 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 15 : diff -r d2e78612ed03 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 16 : diff -r d2e78612ed03 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 17 : diff -r e5b12367190b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 18 : diff -r e5b12367190b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 19 : diff -r a2fe41181fe1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 20 : diff -r a2fe41181fe1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 21 : diff -r a2fe41181fe1 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+794 lines, -718 lines) Patch
M src/cmd/gc/builtin.c View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/go.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/gc/reflect.c View 3 chunks +38 lines, -2 lines 0 comments Download
M src/cmd/gc/runtime.go View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/walk.c View 1 chunk +8 lines, -0 lines 0 comments Download
M src/cmd/ld/dwarf.c View 2 chunks +4 lines, -23 lines 0 comments Download
M src/pkg/reflect/type.go View 8 chunks +38 lines, -12 lines 0 comments Download
M src/pkg/reflect/value.go View 2 chunks +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/chan.c View 23 chunks +690 lines, -607 lines 0 comments Download
M src/pkg/runtime/mgc0.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/runtime/mgc0.c View 7 chunks +0 lines, -59 lines 0 comments Download
M src/pkg/runtime/print.c View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/runtime.h View 6 chunks +2 lines, -8 lines 0 comments Download
M src/pkg/runtime/type.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1
dvyukov
5 months, 1 week ago (2017-05-15 23:35:17 UTC) #1
FTR, this applies and works on top of:

commit 3c3be622011747f6db4b4cf81ed3a975dfca2b51
Date:   Wed Feb 12 22:16:42 2014 +0400
    runtime: concurrent GC sweep
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted