Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(773)

Issue 12541051: code review 12541051: encoding: new package (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by rsc
Modified:
4 years, 3 months ago
Reviewers:
r
CC:
r, golang-dev
Visibility:
Public.

Description

encoding: new package See golang.org/s/go12encoding for design.

Patch Set 1 #

Patch Set 2 : diff -r e052a6dba066 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e052a6dba066 https://code.google.com/p/go/ #

Total comments: 8

Patch Set 4 : diff -r df2050eeba3a https://code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 2ca230b93195 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -2 lines) Patch
M src/cmd/dist/build.c View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
A src/pkg/encoding/encoding.go View 1 2 3 4 1 chunk +48 lines, -0 lines 0 comments Download
M src/pkg/go/build/deps_test.go View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-09 18:00:35 UTC) #1
r
https://codereview.appspot.com/12541051/diff/6001/src/pkg/encoding/encoding.go File src/pkg/encoding/encoding.go (right): https://codereview.appspot.com/12541051/diff/6001/src/pkg/encoding/encoding.go#newcode6 src/pkg/encoding/encoding.go:6: // multiple encoding implementations. this doesn't say much and ...
4 years, 3 months ago (2013-08-10 21:24:47 UTC) #2
rsc
PTAL https://codereview.appspot.com/12541051/diff/6001/src/pkg/encoding/encoding.go File src/pkg/encoding/encoding.go (right): https://codereview.appspot.com/12541051/diff/6001/src/pkg/encoding/encoding.go#newcode6 src/pkg/encoding/encoding.go:6: // multiple encoding implementations. On 2013/08/10 21:24:47, r ...
4 years, 3 months ago (2013-08-13 13:22:54 UTC) #3
r
LGTM https://codereview.appspot.com/12541051/diff/12001/src/pkg/encoding/encoding.go File src/pkg/encoding/encoding.go (right): https://codereview.appspot.com/12541051/diff/12001/src/pkg/encoding/encoding.go#newcode26 src/pkg/encoding/encoding.go:26: // d https://codereview.appspot.com/12541051/diff/12001/src/pkg/encoding/encoding.go#newcode45 src/pkg/encoding/encoding.go:45: // d
4 years, 3 months ago (2013-08-13 22:27:12 UTC) #4
rsc
4 years, 3 months ago (2013-08-14 04:18:24 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=00b5a40ae411 ***

encoding: new package

See golang.org/s/go12encoding for design.

R=r
CC=golang-dev
https://codereview.appspot.com/12541051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4