code review 12541050: strings: add test for some corner cases of Count

strings: add test for Count

[peted, 2013-08-09 17:38:49]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-08-09 17:44:25]

Why a new test and table?

Just add to existing ones?
 On Aug 9, 2013 10:38 AM, <pieter@binky.org.uk> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> strings: add test for some corner cases of Count
>
> Please review this at
https://codereview.appspot.**com/12541050/<https://codereview.appspot.com/125...
>
> Affected files:
>   M src/pkg/strings/strings_test.**go
>
>
> Index: src/pkg/strings/strings_test.**go
> ==============================**==============================**=======
> --- a/src/pkg/strings/strings_**test.go
> +++ b/src/pkg/strings/strings_**test.go
> @@ -1010,6 +1010,28 @@
>         }
>  }
>
> +var CountCornerCases = []struct {
> +       s, sep string
> +       num    int
> +}{
> +       {"", "", 1},
> +       {"", "notempty", 0},
> +       {"notempty", "", 9},
> +       {"smaller", "not smaller", 0},
> +       {"12345678987654321", "6", 2},
> +       {"611161116", "6", 3},
> +       {"notequal", "NotEqual", 0},
> +       {"equal", "equal", 1},
> +}
> +
> +func TestCountCornerCases(t *testing.T) {
> +       for _, tt := range CountCornerCases {
> +               if num := Count(tt.s, tt.sep); num != tt.num {
> +                       t.Errorf("Count(\"%s\", \"%s\") = %d, want %d",
> tt.s, tt.sep, num, tt.num)
> +               }
> +       }
> +}
> +
>  func makeBenchInputHard() string {
>         tokens := [...]string{
>                 "<a>", "<p>", "<b>", "<strong>",
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[peted, 2013-08-09 18:08:00]

On 2013/08/09 17:44:25, bradfitz wrote:
> Why a new test and table?
> 
> Just add to existing ones?

There are no existing tests that check Count's return value that I could find.

[bradfitz, 2013-08-09 19:03:45]

Indeed. Surprising.

In that case, just rename this to "TestCount".  Drop "corner cases", so we
can test normal stuff too.



On Fri, Aug 9, 2013 at 11:08 AM, <pieter@binky.org.uk> wrote:

> On 2013/08/09 17:44:25, bradfitz wrote:
>
>> Why a new test and table?
>>
>
>  Just add to existing ones?
>>
>
> There are no existing tests that check Count's return value that I could
> find.
>
>
https://codereview.appspot.**com/12541050/<https://codereview.appspot.com/125...
>

[peted, 2013-08-09 19:13:16]

On 2013/08/09 19:03:45, bradfitz wrote:
> Indeed. Surprising.
> 
> In that case, just rename this to "TestCount".  Drop "corner cases", so we
> can test normal stuff too.

I added some normal stuff too. PTAL

[bradfitz, 2013-08-09 19:51:07]

LGTM



On Fri, Aug 9, 2013 at 12:13 PM, <pieter@binky.org.uk> wrote:

> On 2013/08/09 19:03:45, bradfitz wrote:
>
>> Indeed. Surprising.
>>
>
>  In that case, just rename this to "TestCount".  Drop "corner cases",
>>
> so we
>
>> can test normal stuff too.
>>
>
> I added some normal stuff too. PTAL
>
>
>
>
https://codereview.appspot.**com/12541050/<https://codereview.appspot.com/125...
>

[bradfitz, 2013-08-09 19:51:22]

*** Submitted as https://code.google.com/p/go/source/detail?r=e87b031b694b ***

strings: add test for Count

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12541050

Committer: Brad Fitzpatrick <bradfitz@golang.org>