Issue 12541047: code review 12541047: cmd/gc: make bitmaps shorter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12541047: code review 12541047: cmd/gc: make bitmaps shorter (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rsc

Modified:
11 years, 7 months ago

Reviewers:

CC:
golang-dev, cshapiro, iant

Visibility:
Public.

Description

cmd/gc: make bitmaps shorter Sort non-pointer-containing data to the low end of the stack frame, and make the bitmaps only cover the pointer-containing top end. Generates significantly less garbage collection bitmap for programs with large byte buffers on the stack. Only 2% shorter for godoc, but 99.99998% shorter in some test cases. Fixes arm build.

Patch Set 1 #

Patch Set 2 : diff -r 4a2be1c8942f https://code.google.com/p/go/ #

Patch Set 3 : diff -r ba1c4231613a https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -19 lines)			Patch
M	src/cmd/gc/go.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/pgen.c	View	1 2	7 chunks	+40 lines, -10 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View	1	3 chunks	+25 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: cshapiro, golang-dev@googlegroups.com, iant), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-08-08 20:38:00 UTC) #1

rsc

11 years, 7 months ago (2013-08-08 20:38:05 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=c3d018ba1af5 ***

cmd/gc: make bitmaps shorter

Sort non-pointer-containing data to the low end of the
stack frame, and make the bitmaps only cover the
pointer-containing top end.

Generates significantly less garbage collection bitmap
for programs with large byte buffers on the stack.

Only 2% shorter for godoc, but 99.99998% shorter
in some test cases.

Fixes arm build.

TBR=golang-dev
CC=cshapiro, golang-dev, iant
https://codereview.appspot.com/12541047

Expand All Messages | Collapse All Messages