code review 12536046: runtime: Better test tracebackability of jmpdefer when ...

runtime: Better test tracebackability of jmpdefer when running a nil defer.

[bradfitz, 2013-08-07 23:27:05]

https://codereview.appspot.com/12536046/diff/3001/test/fixedbugs/issue6055.go
File test/fixedbugs/issue6055.go (right):

https://codereview.appspot.com/12536046/diff/3001/test/fixedbugs/issue6055.go...
test/fixedbugs/issue6055.go:21: n := runtime.Stack(buf[:], true)
or:

   s := string(buf[:runtime.Stack(buf[:], true))
   if strings.Contains(s, "unknown argument frame size") {
       println(s)
   }

[khr, 2013-08-09 16:58:21]

Hello bradfitz@golang.org, dvyukov@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[dvyukov, 2013-08-09 17:00:50]

LGTM

[bradfitz, 2013-08-09 17:10:49]

LGTM
 On Aug 9, 2013 9:58 AM, <khr@golang.org> wrote:

> Reviewers: bradfitz, dvyukov,
>
> Message:
> Hello bradfitz@golang.org, dvyukov@google.com (cc:
> golang-dev@googlegroups.com),
>
> I'd like you to review this change to
>
https://khr%40golang.org@code.**google.com/p/go/<http://40golang.org@code.goo...
>
>
> Description:
> runtime: Better test tracebackability of jmpdefer when running a nil
> defer.
>
> Please review this at
https://codereview.appspot.**com/12536046/<https://codereview.appspot.com/125...
>
> Affected files:
>   M test/fixedbugs/issue6055.go
>
>
> Index: test/fixedbugs/issue6055.go
> ==============================**==============================**=======
> --- a/test/fixedbugs/issue6055.go
> +++ b/test/fixedbugs/issue6055.go
> @@ -6,11 +6,17 @@
>
>  package main
>
> +import "runtime"
> +
>  type Closer interface {
>         Close()
>  }
>
>  func nilInterfaceDeferCall() {
> +       defer func() {
> +               // make sure a traceback happens with jmpdefer on the stack
> +               runtime.GC()
> +       }()
>         var x Closer
>         defer x.Close()
>  }
>
>
>

[khr, 2013-08-09 22:27:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=690c179cc3fd ***

runtime: Better test tracebackability of jmpdefer when running a nil defer.

R=bradfitz, dvyukov
CC=golang-dev
https://codereview.appspot.com/12536046