Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3579)

Issue 12536044: Refactor simplestreams prior to adding tools (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by wallyworld
Modified:
10 years, 8 months ago
Reviewers:
jameinel, fwereade, mp+178878
Visibility:
Public.

Description

Refactor simplestreams prior to adding tools We need to be able to process juju tools simplestreams metadata. To make this easy to add, the existing code needed to besplit into generic and type specific parts. Most of the functionality is provided by the framework. The type specifc parts involve defining a struct to receive the data and a function to do the filtering. The imagemetadata specific artifacts are provided. The next branch will add the tools specific artifacts. https://code.launchpad.net/~wallyworld/juju-core/refactor-simplestreams/+merge/178878 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Refactor simplestreams prior to adding tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1184 lines, -904 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/plugins/juju-metadata/imagemetadata.go View 2 chunks +2 lines, -1 line 0 comments Download
M cmd/plugins/juju-metadata/validatemetadata.go View 2 chunks +2 lines, -1 line 0 comments Download
M cmd/plugins/juju-metadata/validatemetadata_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/azure/environ.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M environs/azure/environ_test.go View 1 2 chunks +2 lines, -0 lines 0 comments Download
M environs/azure/instancetype.go View 1 3 chunks +7 lines, -6 lines 0 comments Download
M environs/ec2/ec2.go View 1 2 chunks +2 lines, -1 line 0 comments Download
M environs/ec2/export_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M environs/ec2/image.go View 2 chunks +5 lines, -4 lines 0 comments Download
M environs/ec2/local_test.go View 1 2 chunks +2 lines, -1 line 0 comments Download
M environs/imagemetadata/boilerplate.go View 3 chunks +6 lines, -4 lines 0 comments Download
A environs/imagemetadata/simplestreams.go View 1 chunk +124 lines, -0 lines 0 comments Download
A environs/imagemetadata/simplestreams_test.go View 1 chunk +267 lines, -0 lines 0 comments Download
M environs/imagemetadata/validation.go View 2 chunks +6 lines, -4 lines 0 comments Download
M environs/imagemetadata/validation_test.go View 4 chunks +6 lines, -4 lines 0 comments Download
M environs/instances/image_test.go View 2 chunks +5 lines, -4 lines 0 comments Download
M environs/openstack/export_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M environs/openstack/image.go View 1 2 chunks +5 lines, -4 lines 0 comments Download
M environs/openstack/local_test.go View 1 2 chunks +2 lines, -1 line 0 comments Download
M environs/openstack/provider.go View 1 2 chunks +2 lines, -1 line 0 comments Download
M environs/simplestreams/decode.go View 1 chunk +1 line, -1 line 0 comments Download
A environs/simplestreams/export_test.go View 1 1 chunk +31 lines, -0 lines 0 comments Download
M environs/simplestreams/simplestreams.go View 1 18 chunks +249 lines, -237 lines 0 comments Download
M environs/simplestreams/simplestreams_test.go View 1 7 chunks +134 lines, -620 lines 0 comments Download
A environs/simplestreams/testing/testing.go View 1 chunk +311 lines, -0 lines 0 comments Download

Messages

Total messages: 4
wallyworld
Please take a look.
10 years, 9 months ago (2013-08-07 04:47:07 UTC) #1
wallyworld
Please take a look.
10 years, 8 months ago (2013-08-12 03:10:02 UTC) #2
jameinel
This looks mostly like just splitting out some bits into a different package, and then ...
10 years, 8 months ago (2013-08-13 13:44:04 UTC) #3
fwereade
10 years, 8 months ago (2013-08-13 15:06:01 UTC) #4
Sorry, I "reviewed" this last week and never mailed it. LGTM, thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b