Issue 12532043: code review 12532043: 9term: set TERM=dumb instead of TERM=9term

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12532043: code review 12532043: 9term: set TERM=dumb instead of TERM=9term (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rsc

Modified:
11 years, 5 months ago

Reviewers:

CC:
rsc, r

Visibility:
Public.

Description

9term: set TERM=dumb instead of TERM=9term Everyone seems to assume that TERM != dumb implies ANSI escape codes are okay. In fact, many people assume that unconditionally, but it is easier to argue back about TERM=dumb than TERM=9term. This applies to acme win too, because they share the code. Set termprog=9term or termprog=win for clients who need to know.

Patch Set 1 #

Patch Set 2 : diff -r ed977a71537f https://code.google.com/p/plan9port #

Patch Set 3 : diff -r ed977a71537f https://code.google.com/p/plan9port #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
M	src/cmd/9term/9term.c	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/9term/rcstart.c	View	1 2	1 chunk	+10 lines, -1 line	0 comments	Download
M	src/cmd/9term/term.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/9term/win.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc (cc: r), I'd like you to review this change to https://code.google.com/p/plan9port

11 years, 5 months ago (2013-08-06 13:42:02 UTC) #1

rsc

11 years, 5 months ago (2013-08-06 13:42:13 UTC) #2

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=e5582678d70f ***

9term: set TERM=dumb instead of TERM=9term

Everyone seems to assume that TERM != dumb implies
ANSI escape codes are okay. In fact, many people assume
that unconditionally, but it is easier to argue back about
TERM=dumb than TERM=9term.

This applies to acme win too, because they share the code.

Set termprog=9term or termprog=win for clients who
need to know.

R=rsc
CC=r
https://codereview.appspot.com/12532043

Expand All Messages | Collapse All Messages