Issue 12531043: code review 12531043: runtime: do not run TestCgoSignalDeadlock on windows in...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12531043: code review 12531043: runtime: do not run TestCgoSignalDeadlock on windows in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 7 months ago

Reviewers:
brainman

CC:
golang-dev, brainman

Visibility:
Public.

Description

runtime: do not run TestCgoSignalDeadlock on windows in short mode The test takes up to 64 seconds on windows builders. I've tried to reduce number of iterations in the test, but it does not affect run time. Fixes issue 6054.

Patch Set 1 #

Patch Set 2 : diff -r 50c9f3544eed https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 50c9f3544eed https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d91993212194 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r d91993212194 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r d91993212194 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/pkg/runtime/crash_cgo_test.go	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-06 13:28:39 UTC) #1

dvyukov

On Wed, Aug 7, 2013 at 3:50 AM, <alex.brainman@gmail.com> wrote: > LGTM > > Should ...

11 years, 7 months ago (2013-08-07 20:04:00 UTC) #3

dvyukov

11 years, 7 months ago (2013-08-07 20:04:37 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=34399c318fa2 ***

runtime: do not run TestCgoSignalDeadlock on windows in short mode
The test takes up to 64 seconds on windows builders.
I've tried to reduce number of iterations in the test,
but it does not affect run time.
Fixes issue 6054.

R=golang-dev, alex.brainman
CC=golang-dev
https://codereview.appspot.com/12531043

Expand All Messages | Collapse All Messages