code review 12530044: misc/notepadplus: fix functionList regex issue

misc/notepadplus: fix functionList regex issue

The receiver name is optional. when Method's receiver name messing,
the functionList regex can't match the Method,
e.g. `func (*T) ProtoMessage() {}`.

[chai2010, 2013-08-08 07:23:43]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
http://code.google.com/p/go

[bradfitz, 2013-08-08 17:57:13]

LGTM



On Thu, Aug 8, 2013 at 12:23 AM, <chaishushan@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> http://code.google.com/p/go
>
>
> Description:
> misc/notepadplus: fix functionList regex issue
>
> The receiver name is optional. when Method's receiver name messing,
> the functionList regex can't match the Method,
> e.g. `func (*T) ProtoMessage() {}`.
>
> Please review this at
https://codereview.appspot.**com/12530044/<https://codereview.appspot.com/125...
>
> Affected files:
>   M misc/notepadplus/functionList.**xml
>
>
> Index: misc/notepadplus/functionList.**xml
> ==============================**==============================**=======
> --- a/misc/notepadplus/**functionList.xml
> +++ b/misc/notepadplus/**functionList.xml
> @@ -7,7 +7,7 @@
>                 <!-- <parsers> -->
>                         <parser id="go" displayName="Go"
> commentExpr="((/\*.*?\*)/|(//.***?$))">
>                                 <function
> -                                       mainExpr="(^func\s+\w+)|(^**
> func\s*\(\s*\w+\s*\*?\s*\w+\s***\)\s*\w+)"
> +                                       mainExpr="(^func\s+\w+)|(^**
> func\s*\(\s*\w*\s*\*?\s*\w+\s***\)\s*\w+)"
>                                         displayMode="$className->$**
> functionName">
>                                         <functionName>
>                                                 <nameExpr
> expr="((func\s+\w+)|(\)\s*\w+)**)"/>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[bradfitz, 2013-08-08 17:57:35]

*** Submitted as https://code.google.com/p/go/source/detail?r=b38fdb6c22c1 ***

misc/notepadplus: fix functionList regex issue

The receiver name is optional. when Method's receiver name messing,
the functionList regex can't match the Method,
e.g. `func (*T) ProtoMessage() {}`.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12530044

Committer: Brad Fitzpatrick <bradfitz@golang.org>