Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7088)

Issue 12523044: Recognise more name attributes

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by ekasper
Modified:
10 years, 8 months ago
Reviewers:
Al Cutter, Eran
CC:
ctlog-opensource-review_google.com
Visibility:
Public.

Description

Recognise more name attributes

Patch Set 1 #

Patch Set 2 : width #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -35 lines) Patch
M src/python/ct/crypto/asn1/oid.py View 3 chunks +42 lines, -30 lines 0 comments Download
M src/python/ct/crypto/asn1/x509_name.py View 1 3 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 5
ekasper
Add some naming attributes that are not part of the recommended standard set but that ...
10 years, 8 months ago (2013-08-06 12:26:43 UTC) #1
Eran
Totally optional: Have a strict-mode option, which, when set, does not try to parse as ...
10 years, 8 months ago (2013-08-06 12:42:13 UTC) #2
ekasper
On Tue, Aug 6, 2013 at 2:42 PM, <eranm@google.com> wrote: > Totally optional: Have a ...
10 years, 8 months ago (2013-08-06 13:02:20 UTC) #3
Al Cutter
LGTM
10 years, 8 months ago (2013-08-06 13:24:05 UTC) #4
Eran
10 years, 8 months ago (2013-08-06 13:34:27 UTC) #5
On 2013/08/06 13:02:20, ekasper wrote:
> On Tue, Aug 6, 2013 at 2:42 PM, <mailto:eranm@google.com> wrote:
> 
> > Totally optional: Have a strict-mode option, which, when set, does not
> > try to parse as DirectoryString, keeping the old behaviour.
> >
> 
> Do you have a use case for this strict mode?
> 
> The RFC says: "The type of the component AttributeValue is determined by
> the AttributeType; in general it will be a DirectoryString." and in the
> first 65k certs, I haven't seen a single one that isn't.
> 
> 
> >
>
https://codereview.appspot.**com/12523044/%3Chttps://codereview.appspot.com/1...>
> >

No, I don't have a use case - disregard my suggestion.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b