Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150)

Issue 12523043: Update the zoom slider styles per UX

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by rharding
Modified:
11 years, 11 months ago
Reviewers:
mp+178730, jeff.pihach
Visibility:
Public.

Description

Update the zoom slider styles per UX https://code.launchpad.net/~rharding/juju-gui/zoom-slider-update/+merge/178730 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update the zoom slider styles per UX #

Total comments: 2

Patch Set 3 : Update the zoom slider styles per UX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -6 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/non-sprites/zoom-handle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/zoom_m_h.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/zoom_minus.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/zoom_minus_pressed.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/zoom_p_h.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/zoom_plus.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/zoom_plus_press.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M app/templates/right-sidebar.partial View 1 1 chunk +2 lines, -2 lines 0 comments Download
M app/views/topology/panzoom.js View 1 3 chunks +48 lines, -3 lines 0 comments Download
M lib/views/stylesheet.less View 1 2 1 chunk +42 lines, -8 lines 0 comments Download

Messages

Total messages: 6
rharding
Please take a look.
11 years, 11 months ago (2013-08-06 11:42:14 UTC) #1
rharding
LTM This qa'd ok for me in FF and Chrome. I'd like to get the ...
11 years, 11 months ago (2013-08-06 11:54:50 UTC) #2
rharding
I don't see the pressed images used anywhere? We also don't need the skin-sam bits ...
11 years, 11 months ago (2013-08-06 17:24:42 UTC) #3
jeff.pihach
LGTM with the changes mentioned below. QA OK https://codereview.appspot.com/12523043/diff/6001/lib/views/stylesheet.less File lib/views/stylesheet.less (right): https://codereview.appspot.com/12523043/diff/6001/lib/views/stylesheet.less#newcode969 lib/views/stylesheet.less:969: .yui3-skin-sam ...
11 years, 11 months ago (2013-08-06 17:29:25 UTC) #4
rharding
LGTM verified that the skin-sam is required and removed the two extra images.
11 years, 11 months ago (2013-08-06 17:36:16 UTC) #5
rharding
11 years, 11 months ago (2013-08-06 17:41:06 UTC) #6
*** Submitted:

Update the zoom slider styles per UX

R=jeff.pihach
CC=
https://codereview.appspot.com/12523043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b