[dev.power64] code review 125210043: test/nosplit.go: add power64 support

test/nosplit.go: add power64 support

[minux, 2014-08-13 07:36:08]

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to the dev.power64 branch of
https://code.google.com/p/go

[iant, 2014-08-13 13:05:02]

https://codereview.appspot.com/125210043/diff/40001/test/nosplit.go
File test/nosplit.go (right):

https://codereview.appspot.com/125210043/diff/40001/test/nosplit.go#newcode242
test/nosplit.go:242: ptrSize = 8
The old code did #define REGISTER AX for the amd64 case.  Not needed?

[rsc, 2014-08-13 14:48:00]

LGTM after fixing amd64

https://codereview.appspot.com/125210043/diff/40001/test/nosplit.go
File test/nosplit.go (right):

https://codereview.appspot.com/125210043/diff/40001/test/nosplit.go#newcode242
test/nosplit.go:242: ptrSize = 8
On 2014/08/13 13:05:02, iant wrote:
> The old code did #define REGISTER AX for the amd64 case.  Not needed?

Needed. Please fix.

[rsc, 2014-08-14 17:59:59]

*** Submitted as https://code.google.com/p/go/source/detail?r=9c7b62a3b22a ***

[dev.power64] test/nosplit.go: add power64 support

LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/125210043

Committer: Russ Cox <rsc@golang.org>

[gobot, 2014-08-15 12:03:32]

This CL appears to have broken the linux-arm-arm5 builder.
See http://build.golang.org/log/d29e36ee90c1e8f8bfdf183fdc7abb70df72007e

[dave_cheney.net, 2014-08-15 12:05:46]

Ignore, this is an unrelated local issue on that builder.

On Fri, Aug 15, 2014 at 10:03 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the linux-arm-arm5 builder.
> See http://build.golang.org/log/d29e36ee90c1e8f8bfdf183fdc7abb70df72007e
>
>
> https://codereview.appspot.com/125210043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.