code review 12513044: image: Inline example image data to make it runnabl...

image: Inline example image data to make it runnable on playground.

Use more compressed image to reduce source clutter.

Fixes issue 5983.

[dtcaciuc, 2013-08-06 23:28:24]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[nigeltao, 2013-08-07 00:47:36]

adg, is this something worth doing?

https://codereview.appspot.com/12513044/diff/6001/src/pkg/image/decode_exampl...
File src/pkg/image/decode_example_test.go (right):

https://codereview.appspot.com/12513044/diff/6001/src/pkg/image/decode_exampl...
src/pkg/image/decode_example_test.go:32: reader :=
base64.NewDecoder(base64.StdEncoding, bytes.NewBufferString(video001))
bytes.NewBufferString should be strings.NewReader.

https://codereview.appspot.com/12513044/diff/6001/src/pkg/image/decode_exampl...
src/pkg/image/decode_example_test.go:83: video001 = `
const video001 = `

[dtcaciuc, 2013-08-07 16:48:35]

Hello nigeltao@golang.org, adg@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[nigeltao, 2013-08-16 01:14:22]

adg: ping.

[adg, 2013-08-16 01:27:41]

Looks fine to me

https://codereview.appspot.com/12513044/diff/11001/src/pkg/image/decode_examp...
File src/pkg/image/decode_example_test.go (right):

https://codereview.appspot.com/12513044/diff/11001/src/pkg/image/decode_examp...
src/pkg/image/decode_example_test.go:82: const video001 = `
I'd be inclined to just write

var reader = base64.NewDecoder(base64.StdEncoding, strings.NewReader(`...`))

[nigeltao, 2013-08-16 01:43:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=7c02aea39eae ***

    image: Inline example image data to make it runnable on playground.

Use more compressed image to reduce source clutter.

Fixes issue 5983.

R=nigeltao, adg
CC=golang-dev
https://codereview.appspot.com/12513044

Committer: Nigel Tao <nigeltao@golang.org>

https://codereview.appspot.com/12513044/diff/11001/src/pkg/image/decode_examp...
File src/pkg/image/decode_example_test.go (right):

https://codereview.appspot.com/12513044/diff/11001/src/pkg/image/decode_examp...
src/pkg/image/decode_example_test.go:82: const video001 = `
On 2013/08/16 01:27:42, adg wrote:
> I'd be inclined to just write
> 
> var reader = base64.NewDecoder(base64.StdEncoding, strings.NewReader(`...`))

Eh, I like it as is, leaving data as data and code as code.