Issue 125100044: code review 125100044: goprotobuf: Fix handling of empty string defaults for '...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 125100044: code review 125100044: goprotobuf: Fix handling of empty string defaults for '... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dsymonds

Modified:
11 years, 3 months ago

Reviewers:
djd

CC:
djd, golang-codereviews

Visibility:
Public.

Description

goprotobuf: Fix handling of empty string defaults for 'string' and 'bytes' fields. This is a bit of an edge case. All other valid defaults appear as non-empty strings, but we need to distinguish [default=""] for string/bytes to uphold the SetDefaults contract.

Patch Set 1 #

Patch Set 2 : diff -r 74b407a42099 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 74b407a42099 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 74b407a42099 https://code.google.com/p/goprotobuf #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -17 lines)			Patch
M	proto/all_test.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	proto/lib.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/properties.go	View	3 chunks	+14 lines, -11 lines	0 comments	Download
M	proto/testdata/test.proto	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	protoc-gen-go/generator/generator.go	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello djd@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

11 years, 3 months ago (2014-08-12 02:07:01 UTC) #1

dsymonds

11 years, 3 months ago (2014-08-12 03:11:23 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=6696293829a4 ***

goprotobuf: Fix handling of empty string defaults for 'string' and 'bytes'
fields.

This is a bit of an edge case. All other valid defaults appear as
non-empty strings, but we need to distinguish [default=""] for string/bytes
to uphold the SetDefaults contract.

LGTM=djd
R=djd
CC=golang-codereviews
https://codereview.appspot.com/125100044

Expand All Messages | Collapse All Messages