Visual bug fixes and updates

Visual bug fixes and updates

From: https://docs.google.com/a/canonical.com/document/d/1pMrGbUT9NTYXU7Rnc73omK687TEGBA0z2s1IoZTyfYk/edit# (and a few extra changes).

Inspector charm details must be the same size as the inspector panel.
Checkbox for expose service should look like checkbox for default configuration
Help text should not be justified but left aligned; also not italic
Remove Hide/show help toggle
Destroy service should be sticky for ghost and not sticky for post deployment.  
In post-deployment, "Destroy service" should only exist on post deployment status, not config or constraint tabs.
Confirm and cancel on config tab should be sticky on bottom
Confirm on config tab should be "Save Changes"
buttons on selections: "replace" should be the only one visible for running; no buttons should be visible for pending.
Fixed charm detail link appearance (bug #1201866).
Added texture to background of browser.
Fixed position issues with active charms.

https://code.launchpad.net/~huwshimi/juju-gui/iom-changes/+merge/178661

(do not edit description out of merge proposal)

[huwshimi, 2013-08-06 06:29:52]

Please take a look.

[jeff.pihach, 2013-08-06 14:35:55]

Thanks for all of these fixes - there are a few issues mentioned below.

QA failed because the post-deploy inspector is 100% height no matter what the
content which makes the overview look bad

https://codereview.appspot.com/12506044/diff/1/app/templates/service-configur...
File app/templates/service-configuration.partial (right):

https://codereview.appspot.com/12506044/diff/1/app/templates/service-configur...
app/templates/service-configuration.partial:57: <div class="yui3-g controls
viewlet-manager-footer">
This class should not go here because the wrapper may still require a general
footer at some point.

https://codereview.appspot.com/12506044/diff/1/app/views/inspector.js
File app/views/inspector.js (left):

https://codereview.appspot.com/12506044/diff/1/app/views/inspector.js#oldcode...
app/views/inspector.js:1120: var img = node.one('img');
Is this not still needed? The server could update it's exposed status and the
GUI would have to update accordingly

https://codereview.appspot.com/12506044/diff/1/lib/views/juju-inspector.less
File lib/views/juju-inspector.less (right):

https://codereview.appspot.com/12506044/diff/1/lib/views/juju-inspector.less#...
lib/views/juju-inspector.less:470: .viewlet-manager-footer {
If this class gets moved back to its original location then this should be
reverted back to relative.

[gary.poster, 2013-08-06 22:50:08]

Hi Huw.  It's very late here, and I didn't quite finish up.  I fixed some of the
issues I found in qa on this branch: 

lp:~gary/juju-gui/iom-changes

The only qa issues I know of right now are these:

- The save changes button on the post-deploy inspector is broken now.

- The expose toggle only works some of the time.  When it is broken, the
"expose" icon appears on the service, but the toggle doesn't change.

If you can merge my branch, fix the first bug, qa the rest of what I did and
change as desired, and file a bug for the second problem (at least it works
*some* of the time now) I would be OK with landing this (LGTM).

Thanks

Gary

[gary.poster, 2013-08-06 22:50:34]

On 2013/08/06 22:50:08, gary.poster wrote:
> Hi Huw.  It's very late here, and I didn't quite finish up.  I fixed some of
the
> issues I found in qa on this branch: 
> 
> lp:~gary/juju-gui/iom-changes
> 
> The only qa issues I know of right now are these:
> 
> - The save changes button on the post-deploy inspector is broken now.
> 
> - The expose toggle only works some of the time.  When it is broken, the
> "expose" icon appears on the service, but the toggle doesn't change.
> 
> If you can merge my branch, fix the first bug, qa the rest of what I did and
> change as desired, and file a bug for the second problem (at least it works
> *some* of the time now) I would be OK with landing this (LGTM).
> 
> Thanks
> 
> Gary

I meant to say, thank you very much for all the fixes here!

Gary

[huwshimi, 2013-08-07 06:44:02]

Please take a look.

[huwshimi, 2013-08-07 06:49:58]

On 2013/08/07 06:44:02, huwshimi wrote:
> Please take a look.

Thanks for the reviews and updates.

I couldn't figure out the reason for the toggle not updating (it looks like the
update event is being fired but the listener doesn't get called). Bug here:
https://bugs.launchpad.net/juju-gui/+bug/1209097

I also fixed some tests and updated the height of the side panel so that it
always matches the current height of the inspector.

[gary.poster, 2013-08-07 22:42:36]

On 2013/08/07 06:49:58, huwshimi wrote:
> On 2013/08/07 06:44:02, huwshimi wrote:
> > Please take a look.
> 
> Thanks for the reviews and updates.

Thank you, Huw!

> 
> I couldn't figure out the reason for the toggle not updating (it looks like
the
> update event is being fired but the listener doesn't get called). Bug here:
> https://bugs.launchpad.net/juju-gui/+bug/1209097
> 
> I also fixed some tests and updated the height of the side panel so that it
> always matches the current height of the inspector.

The only thing is that the side panel is supposed to always be fully extended,
as I had it.  If you could fix that it would be great.

Gary

[jeff.pihach, 2013-08-07 22:58:49]

LGTM with Gary's comment about the details height issue.

In QA'ing I found an odd bug - After deploying a charm and opening the inspector
on that service go to the settings panel and click 'save changes' it'll change
to 'confirm'. This can probably be pushed to a follow-up as it appears to still
save the changes to the model.

[huwshimi, 2013-08-07 23:33:35]

Please take a look.

[huwshimi, 2013-08-07 23:40:03]

On 2013/08/07 23:33:35, huwshimi wrote:
> Please take a look.

Reverted my height change. Submitting.

[huwshimi, 2013-08-08 00:10:13]

Please take a look.

[huwshimi, 2013-08-08 00:23:25]

*** Submitted:

Visual bug fixes and updates

From:
https://docs.google.com/a/canonical.com/document/d/1pMrGbUT9NTYXU7Rnc73omK687...
(and a few extra changes).

Inspector charm details must be the same size as the inspector panel.
Checkbox for expose service should look like checkbox for default configuration
Help text should not be justified but left aligned; also not italic
Remove Hide/show help toggle
Destroy service should be sticky for ghost and not sticky for post deployment.  
In post-deployment, "Destroy service" should only exist on post deployment
status, not config or constraint tabs.
Confirm and cancel on config tab should be sticky on bottom
Confirm on config tab should be "Save Changes"
buttons on selections: "replace" should be the only one visible for running; no
buttons should be visible for pending.
Fixed charm detail link appearance (bug #1201866).
Added texture to background of browser.
Fixed position issues with active charms.

R=jeff.pihach, gary.poster
CC=
https://codereview.appspot.com/12506044