Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(262)

Issue 12494043: Fixes bug #1208503 CSS build duplication (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by huwshimi
Modified:
11 years, 11 months ago
Reviewers:
mp+178647, jeff.pihach
Visibility:
Public.

Description

Fixes bug #1208503 CSS build duplication This was broken because the less and sass builders needed to append files together but once sass was removed the less builder needed to be updated to overwrite the stylesheet. https://code.launchpad.net/~huwshimi/juju-gui/fix-css-append-on-build-1208503/+merge/178647 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes bug #1208503 CSS build duplication #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/templates.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
huwshimi
Please take a look.
11 years, 11 months ago (2013-08-06 00:08:10 UTC) #1
jeff.pihach
LGTM Thanks for the quick fix!
11 years, 11 months ago (2013-08-06 00:10:24 UTC) #2
huwshimi
11 years, 11 months ago (2013-08-06 00:20:54 UTC) #3
*** Submitted:

Fixes bug #1208503 CSS build duplication

This was broken because the less and sass builders needed to append files
together but once sass was removed the less builder needed to be updated to
overwrite the stylesheet.

R=jeff.pihach
CC=
https://codereview.appspot.com/12494043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b