Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(594)

Issue 124900043: [dev.power64] code review 124900043: runtime: ignore rt_sigaction error if it's for SIGRTMAX. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by minux
Modified:
10 years, 3 months ago
Reviewers:
rsc
CC:
rsc, iant, golang-codereviews
Visibility:
Public.

Description

runtime: ignore rt_sigaction error if it's for SIGRTMAX. Workaround a qemu linux user space emulation bug. ref: http://git.qemu.org/?p=qemu.git;a=blob;f=linux-user/signal.c;h=1141054be2170128d6f7a340b41484b49a255936;hb=HEAD#l82

Patch Set 1 #

Patch Set 2 : diff -r 1129a4022aa64fa2fd3975bf67740eafb80ce526 https://code.google.com/p/go #

Patch Set 3 : diff -r 1129a4022aa64fa2fd3975bf67740eafb80ce526 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 1129a4022aa64fa2fd3975bf67740eafb80ce526 https://code.google.com/p/go #

Patch Set 5 : diff -r 17707ff5f271e10a889ad3eadd587b749ce2a7ea https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/pkg/runtime/os_linux.c View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
minux
Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 ...
10 years, 3 months ago (2014-08-08 07:53:25 UTC) #1
minux
This is for discussion, I'm not sure if it's acceptable. (We can also only skip ...
10 years, 3 months ago (2014-08-08 07:59:21 UTC) #2
rsc
LGTM https://codereview.appspot.com/124900043/diff/20001/src/pkg/runtime/os_linux.c File src/pkg/runtime/os_linux.c (right): https://codereview.appspot.com/124900043/diff/20001/src/pkg/runtime/os_linux.c#newcode315 src/pkg/runtime/os_linux.c:315: // We ignored the error if it's 64 ...
10 years, 3 months ago (2014-08-08 12:59:57 UTC) #3
minux
10 years, 3 months ago (2014-08-12 03:32:37 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=a64952e4b71b ***

[dev.power64] runtime: ignore rt_sigaction error if it's for SIGRTMAX.
Workaround a qemu linux user space emulation bug.
ref:
http://git.qemu.org/?p=qemu.git;a=blob;f=linux-user/signal.c;h=1141054be21701...

LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/124900043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b