Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(305)

Issue 124870043: code review 124870043: runtime: fix nacl/amd64p32 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 7 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

runtime: fix nacl/amd64p32 build C compiler does not support unnamed fields.

Patch Set 1 #

Patch Set 2 : diff -r a8843f90d292b6a04f7ab69a168971afb2ac46ef https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r a8843f90d292b6a04f7ab69a168971afb2ac46ef https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 179dc6045b9ed51299378f7a9fd3d6f9c9c80b8b https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/runtime/defs_nacl_amd64p32.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/signal_nacl_amd64p32.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago (2014-08-07 19:34:47 UTC) #1
bradfitz
LGTM On Aug 7, 2014 12:34 PM, "dvyukov via golang-codereviews" < golang-codereviews@googlegroups.com> wrote: > Reviewers: ...
10 years, 7 months ago (2014-08-07 19:36:36 UTC) #2
dvyukov
10 years, 7 months ago (2014-08-07 19:47:07 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=412470452bf8 ***

runtime: fix nacl/amd64p32 build
C compiler does not support unnamed fields.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/124870043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b