code review 12486044: strings: add IndexByte benchmark

strings: add IndexByte benchmark

Like existing Index, IndexRune, IndexHardN, etc.

[bradfitz, 2013-08-06 20:53:38]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-08-06 20:54:11]

Forgot to mail this earlier.



On Tue, Aug 6, 2013 at 1:53 PM, <bradfitz@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> strings: add IndexByte benchmark
>
> Like existing Index, IndexRune, IndexHardN, etc.
>
> Please review this at
https://codereview.appspot.**com/12486044/<https://codereview.appspot.com/124...
>
> Affected files:
>   M src/pkg/strings/strings_test.**go
>
>
> Index: src/pkg/strings/strings_test.**go
> ==============================**==============================**=======
> --- a/src/pkg/strings/strings_**test.go
> +++ b/src/pkg/strings/strings_**test.go
> @@ -168,6 +168,15 @@
>         }
>  }
>
> +func BenchmarkIndexByte(b *testing.B) {
> +       if got := IndexByte(benchmarkString, 'v'); got != 17 {
> +               b.Fatalf("wrong index: expected 17, got=%d", got)
> +       }
> +       for i := 0; i < b.N; i++ {
> +               IndexByte(benchmarkString, 'v')
> +       }
> +}
> +
>  var explodetests = []struct {
>         s string
>         n int
>
>
>

[khr1, 2013-08-06 21:37:15]

LGTM.

What's the difference between the new and old implementations on this
benchmark?


On Tue, Aug 6, 2013 at 1:54 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> Forgot to mail this earlier.
>
>
>
> On Tue, Aug 6, 2013 at 1:53 PM, <bradfitz@golang.org> wrote:
>
>> Reviewers: golang-dev1,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://go.googlecode.com/hg/
>>
>>
>> Description:
>> strings: add IndexByte benchmark
>>
>> Like existing Index, IndexRune, IndexHardN, etc.
>>
>> Please review this at
https://codereview.appspot.**com/12486044/<https://codereview.appspot.com/124...
>>
>> Affected files:
>>   M src/pkg/strings/strings_test.**go
>>
>>
>> Index: src/pkg/strings/strings_test.**go
>> ==============================**==============================**=======
>> --- a/src/pkg/strings/strings_**test.go
>> +++ b/src/pkg/strings/strings_**test.go
>> @@ -168,6 +168,15 @@
>>         }
>>  }
>>
>> +func BenchmarkIndexByte(b *testing.B) {
>> +       if got := IndexByte(benchmarkString, 'v'); got != 17 {
>> +               b.Fatalf("wrong index: expected 17, got=%d", got)
>> +       }
>> +       for i := 0; i < b.N; i++ {
>> +               IndexByte(benchmarkString, 'v')
>> +       }
>> +}
>> +
>>  var explodetests = []struct {
>>         s string
>>         n int
>>
>>
>>
>  --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

[bradfitz, 2013-08-06 21:40:20]

46.8 ns/op to 31.4 ns/op.



On Tue, Aug 6, 2013 at 2:37 PM, Keith Randall <khr@google.com> wrote:

> LGTM.
>
> What's the difference between the new and old implementations on this
> benchmark?
>
>
> On Tue, Aug 6, 2013 at 1:54 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:
>
>> Forgot to mail this earlier.
>>
>>
>>
>> On Tue, Aug 6, 2013 at 1:53 PM, <bradfitz@golang.org> wrote:
>>
>>> Reviewers: golang-dev1,
>>>
>>> Message:
>>> Hello golang-dev@googlegroups.com,
>>>
>>> I'd like you to review this change to
>>> https://go.googlecode.com/hg/
>>>
>>>
>>> Description:
>>> strings: add IndexByte benchmark
>>>
>>> Like existing Index, IndexRune, IndexHardN, etc.
>>>
>>> Please review this at
https://codereview.appspot.**com/12486044/<https://codereview.appspot.com/124...
>>>
>>> Affected files:
>>>   M src/pkg/strings/strings_test.**go
>>>
>>>
>>> Index: src/pkg/strings/strings_test.**go
>>> ==============================**==============================**=======
>>> --- a/src/pkg/strings/strings_**test.go
>>> +++ b/src/pkg/strings/strings_**test.go
>>> @@ -168,6 +168,15 @@
>>>         }
>>>  }
>>>
>>> +func BenchmarkIndexByte(b *testing.B) {
>>> +       if got := IndexByte(benchmarkString, 'v'); got != 17 {
>>> +               b.Fatalf("wrong index: expected 17, got=%d", got)
>>> +       }
>>> +       for i := 0; i < b.N; i++ {
>>> +               IndexByte(benchmarkString, 'v')
>>> +       }
>>> +}
>>> +
>>>  var explodetests = []struct {
>>>         s string
>>>         n int
>>>
>>>
>>>
>>  --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>
>

[bradfitz, 2013-08-06 21:41:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=626c01d29570 ***

strings: add IndexByte benchmark

Like existing Index, IndexRune, IndexHardN, etc.

R=golang-dev, khr
CC=golang-dev
https://codereview.appspot.com/12486044