Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 12483043: code review 12483043: strings: use runtime assembly for IndexByte (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by bradfitz
Modified:
5 years, 8 months ago
Reviewers:
khr
CC:
golang-dev, khr
Visibility:
Public.

Description

strings: use runtime assembly for IndexByte Fixes issue 3751

Patch Set 1 #

Patch Set 2 : diff -r ffe930a195f4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e285a7b170aa https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -15 lines) Patch
M src/pkg/runtime/asm_386.s View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 2 4 chunks +23 lines, -4 lines 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M src/pkg/strings/strings.go View 1 1 chunk +0 lines, -10 lines 0 comments Download
A src/pkg/strings/strings.s View 1 1 chunk +5 lines, -0 lines 0 comments Download
A src/pkg/strings/strings_decl.go View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
5 years, 8 months ago (2013-08-05 21:26:41 UTC) #1
khr
On 2013/08/05 21:26:41, bradfitz wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
5 years, 8 months ago (2013-08-05 21:32:00 UTC) #2
bradfitz
5 years, 8 months ago (2013-08-05 22:04:08 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=816f25454af2 ***

strings: use runtime assembly for IndexByte

Fixes issue 3751

R=golang-dev, khr
CC=golang-dev
https://codereview.appspot.com/12483043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b