Issue 12482044: code review 12482044: build: change how cmd/api is run in run.bash and run.bat

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12482044: code review 12482044: build: change how cmd/api is run in run.bash and run.bat (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bradfitz

Modified:
11 years, 7 months ago

Reviewers:
gri

CC:
golang-dev, gri

Visibility:
Public.

Description

build: change how cmd/api is run in run.bash and run.bat In prep for Robert's forthcoming cmd/api rewrite which depends on the go.tools subrepo, we'll need to be more careful about how and when we run cmd/api. Rather than implement this policy in both run.bash and run.bat, this change moves the policy and mechanism into cmd/api/run.go, which will then evolve. The plan is in a TODO in run.go.

Patch Set 1 #

Patch Set 2 : diff -r cfc3eab6195a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cfc3eab6195a https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 60d62a3b3991 https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -8 lines)			Patch
M	misc/dist/bindist.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A	src/cmd/api/run.go	View	1 2 3	1 chunk	+65 lines, -0 lines	0 comments	Download
M	src/run.bash	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/run.bat	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-07 18:01:51 UTC) #1

gri

LGTM https://codereview.appspot.com/12482044/diff/7001/src/cmd/api/run.go File src/cmd/api/run.go (right): https://codereview.appspot.com/12482044/diff/7001/src/cmd/api/run.go#newcode29 src/cmd/api/run.go:29: goroot = os.Getenv("GOROOT") perhaps add a comment that ...

11 years, 7 months ago (2013-08-07 20:23:23 UTC) #2

bradfitz

11 years, 7 months ago (2013-08-07 20:49:40 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=c71f9b21cc13 ***

build: change how cmd/api is run in run.bash and run.bat

In prep for Robert's forthcoming cmd/api rewrite which
depends on the go.tools subrepo, we'll need to be more
careful about how and when we run cmd/api.

Rather than implement this policy in both run.bash and
run.bat, this change moves the policy and mechanism into
cmd/api/run.go, which will then evolve.

The plan is in a TODO in run.go.

R=golang-dev, gri
CC=golang-dev
https://codereview.appspot.com/12482044

Expand All Messages | Collapse All Messages