apiserver: common AgentEntityWatcher mixin

apiserver: common AgentEntityWatcher mixin

Last step of Machiner API refactoring - extracted
the Watch method as a reusable AgentEntityWatcher
mixin and changed the machiner to use it. It will
be used by the upcoming Uniter API as well.

https://code.launchpad.net/~dimitern/juju-core/090-api-agententitywatcher/+merge/178578

Requires: https://code.launchpad.net/~dimitern/juju-core/089-api-ensuredeader/+merge/178545

(do not edit description out of merge proposal)

[dimitern, 2013-08-05 14:44:22]

Please take a look.

[dimitern, 2013-08-05 14:58:35]

Please take a look.

[gz, 2013-08-05 16:41:48]

LGTM.

https://codereview.appspot.com/12464043/diff/4001/state/apiserver/common/watc...
File state/apiserver/common/watch.go (right):

https://codereview.appspot.com/12464043/diff/4001/state/apiserver/common/watc...
state/apiserver/common/watch.go:20: type AgentEntityWatcherer interface {
Morerer. ;_;

[rog, 2013-08-05 16:50:12]

LGTM

https://codereview.appspot.com/12464043/diff/4001/state/apiserver/common/watc...
File state/apiserver/common/watch.go (right):

https://codereview.appspot.com/12464043/diff/4001/state/apiserver/common/watc...
state/apiserver/common/watch.go:20: type AgentEntityWatcherer interface {
I'm only letting this name go through because it's going away very soon :-)

https://codereview.appspot.com/12464043/diff/4001/state/apiserver/common/watc...
state/apiserver/common/watch.go:56: func (a *AgentEntityWatcher) Watch(args
params.Entities) (params.NotifyWatchResults, error) {
For future consideration: make this more general so that
UpgraderAPI.WatchAPIVersion and other similar watcher API entry
points can use it.

https://codereview.appspot.com/12464043/diff/4001/state/state.go
File state/state.go (right):

https://codereview.appspot.com/12464043/diff/4001/state/state.go#newcode648
state/state.go:648: func (st *State) AgentEntityWatcher(tag string)
(AgentEntityWatcher, error) {
wot no tests?

[dimitern, 2013-08-05 17:05:21]

Please take a look.

https://codereview.appspot.com/12464043/diff/4001/state/apiserver/common/watc...
File state/apiserver/common/watch.go (right):

https://codereview.appspot.com/12464043/diff/4001/state/apiserver/common/watc...
state/apiserver/common/watch.go:56: func (a *AgentEntityWatcher) Watch(args
params.Entities) (params.NotifyWatchResults, error) {
On 2013/08/05 16:50:12, rog wrote:
> For future consideration: make this more general so that
> UpgraderAPI.WatchAPIVersion and other similar watcher API entry
> points can use it.

Will have a look and think about it, thanks.

https://codereview.appspot.com/12464043/diff/4001/state/state.go
File state/state.go (right):

https://codereview.appspot.com/12464043/diff/4001/state/state.go#newcode648
state/state.go:648: func (st *State) AgentEntityWatcher(tag string)
(AgentEntityWatcher, error) {
On 2013/08/05 16:50:12, rog wrote:
> wot no tests?

It will get changed soon anyway. And it's tested in the worker/machiner and the
apiserver/machiner