Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 124640043: code review 124640043: syscall: replace zsyscall_windows_*.go files with a sin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by brainman
Modified:
10 years, 6 months ago
Reviewers:
r, gobot
CC:
golang-codereviews, r
Visibility:
Public.

Description

syscall: replace zsyscall_windows_*.go files with a single file zsyscall_windows_386.go and zsyscall_windows_amd64.go contain same bytes

Patch Set 1 #

Patch Set 2 : diff -r 7e00313f3b3a14e59d607aaab84416289dbc76f6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7e00313f3b3a14e59d607aaab84416289dbc76f6 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0ec777d94204038a95e17cdad3c4886329ba699c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1854 lines) Patch
M src/pkg/syscall/mkall.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mkall_windows.bat View 1 1 chunk +2 lines, -8 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
R src/pkg/syscall/zsyscall_windows_amd64.go View 1 1 chunk +0 lines, -1846 lines 0 comments Download

Messages

Total messages: 4
brainman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 7 months ago (2014-08-20 02:20:31 UTC) #1
r
LGTM
10 years, 7 months ago (2014-08-20 02:51:51 UTC) #2
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=e6cef783012e *** syscall: replace zsyscall_windows_*.go files with a single file zsyscall_windows_386.go and ...
10 years, 7 months ago (2014-08-20 03:17:53 UTC) #3
gobot
10 years, 6 months ago (2014-08-20 11:27:08 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64-race builder.
See http://build.golang.org/log/93920985ab1f8ee9de9f8effae71479470f9f4c7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b