Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 12449043: code review 12449043: goprotobuf: Make UnmarshalText reset the message before... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by dsymonds
Modified:
12 years, 3 months ago
Reviewers:
r
CC:
r, golang-dev
Visibility:
Public.

Description

goprotobuf: Make UnmarshalText reset the message before unmarshaling. This is the expected behaviour, and matches Unmarshal.

Patch Set 1 #

Patch Set 2 : diff -r 4daa80899462 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 4daa80899462 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 4daa80899462 https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M proto/text_parser.go View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
12 years, 3 months ago (2013-08-05 01:33:24 UTC) #1
r
LGTM if you say so. i seem to recall that the old behavior was a ...
12 years, 3 months ago (2013-08-05 03:41:26 UTC) #2
dsymonds
12 years, 3 months ago (2013-08-05 03:53:33 UTC) #3
*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=d54cbe4bdc25 ***

goprotobuf: Make UnmarshalText reset the message before unmarshaling.

This is the expected behaviour, and matches Unmarshal.

R=r
CC=golang-dev
https://codereview.appspot.com/12449043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b