code review 12448044: time: match month and day names only when not followed ...

time: match month and day names only when not followed immediately by a lower-case letter
Avoids seeing "Janet" as "Januaryet".

Fixes issue 6020.

[r, 2013-08-05 00:42:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dsymonds, 2013-08-05 00:45:57]

LGTM

https://codereview.appspot.com/12448044/diff/1/src/pkg/time/format.go
File src/pkg/time/format.go (right):

https://codereview.appspot.com/12448044/diff/1/src/pkg/time/format.go#newcode107
src/pkg/time/format.go:107: func followedByLowerCase(str string, i int) bool {
I might have made this

func startsWithLowerCase(s string) bool {
  if s == "" {
    return false
  }
  c := s[0]
  return 'a' <= c && c <= 'z'
}

and passed layout[i+3:] to this function instead. But this is fine.

[r, 2013-08-05 00:53:53]

*** Submitted as https://code.google.com/p/go/source/detail?r=346fdfe3fbee ***

time: match month and day names only when not followed immediately by a
lower-case letter
Avoids seeing "Janet" as "Januaryet".

Fixes issue 6020.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/12448044