Issue 124350045: code review 124350045: go.sys/plan9: just jump to syscall.Syscall etc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124350045: code review 124350045: go.sys/plan9: just jump to syscall.Syscall etc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by r

Modified:
10 years, 6 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

go.sys/plan9: just jump to syscall.Syscall etc. Don't re-implement these functions.

Patch Set 1 #

Patch Set 2 : diff -r 7e8f794ac00a27c23d9b423ace2066a35351ca20 https://code.google.com/p/go.sys #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -286 lines)			Patch
	M	plan9/asm_plan9_386.s	View		1 chunk	+10 lines, -144 lines	0 comments	Download
	M	plan9/asm_plan9_amd64.s	View		1 chunk	+10 lines, -142 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.sys

10 years, 6 months ago (2014-08-14 18:27:18 UTC) #1

10 years, 6 months ago (2014-08-14 19:05:49 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=fcb35749b216&repo=sys ***

go.sys/plan9: just jump to syscall.Syscall etc.
Don't re-implement these functions.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/124350045

Expand All Messages | Collapse All Messages