Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2447)

Issue 12434043: support css -webkit- prefix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by felix8a
Modified:
10 years, 9 months ago
Reviewers:
MikeSamuel, kamruzzaman060452
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This adds and whitelists a bunch of css properties prefixed by -webkit- based on what http://caniuse.com/#cats=CSS says. I'm just enumerating the duplicate properties since it's not a large list, and browsers are going to stop using -prefix- for new features.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -28 lines) Patch
M src/com/google/caja/lang/css/css-extensions-defs.json View 19 chunks +60 lines, -0 lines 2 comments Download
M src/com/google/caja/lang/css/css-extensions-whitelist.json View 1 chunk +74 lines, -21 lines 0 comments Download
M src/com/google/caja/plugin/sanitizecss.js View 1 chunk +4 lines, -2 lines 1 comment Download
M tests/com/google/caja/plugin/cssparser_test.js View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/sanitizecss_test.js View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7
felix8a
10 years, 9 months ago (2013-08-04 15:55:44 UTC) #1
MikeSamuel
On 2013/08/04 15:55:44, felix8a wrote: I was planning on getting rid of all the prefixed ...
10 years, 9 months ago (2013-08-04 17:47:31 UTC) #2
felix8a
On 2013/08/04 17:47:31, MikeSamuel wrote: > On 2013/08/04 15:55:44, felix8a wrote: > > I was ...
10 years, 9 months ago (2013-08-04 17:49:10 UTC) #3
felix8a
ping
10 years, 9 months ago (2013-08-05 19:00:13 UTC) #4
MikeSamuel
LGTM https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json File src/com/google/caja/lang/css/css-extensions-defs.json (right): https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode123 src/com/google/caja/lang/css/css-extensions-defs.json:123: "as": "visibility" }, might "as": "backface-visibility" be less ...
10 years, 9 months ago (2013-08-05 19:30:37 UTC) #5
felix8a
@r5527 https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json File src/com/google/caja/lang/css/css-extensions-defs.json (right): https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode123 src/com/google/caja/lang/css/css-extensions-defs.json:123: "as": "visibility" }, On 2013/08/05 19:30:37, MikeSamuel wrote: ...
10 years, 9 months ago (2013-08-05 22:18:31 UTC) #6
kamruzzaman060452_gmail.com
10 years, 9 months ago (2013-08-11 17:21:16 UTC) #7
On Tuesday, August 6, 2013 1:00:37 AM UTC+5:30, Mike Samuel wrote:
>
> LGTM 
>
>
>
>
https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/c...

> File src/com/google/caja/lang/css/css-extensions-defs.json (right): 
>
>
https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/c...

>
>
src/com/google/caja/lang/css/css-extensions-defs.json:123<https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode123src/com/google/caja/lang/css/css-extensions-defs.json:123>:

> "as": 
> "visibility" }, 
> might "as": "backface-visibility" be less of a maintenance hazard? 
>
>
>
https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/plugin/san...

> File src/com/google/caja/plugin/sanitizecss.js (right): 
>
>
https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/plugin/san...

>
>
src/com/google/caja/plugin/sanitizecss.js:845<https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/plugin/sanitizecss.js#newcode845src/com/google/caja/plugin/sanitizecss.js:845>:

> atIdent = '@keyframes'; 
> ok 
>
> https://codereview.appspot.com/12434043/ 
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b