Issue 12433043: code review 12433043: net/http: fix Response.Header documentation for multipl...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12433043: code review 12433043: net/http: fix Response.Header documentation for multipl... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by josharian

Modified:
11 years, 10 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

net/http: fix Response.Header documentation for multiple headers with same key Whether the keys are concatenated or separate (or a mixture) depends on the server. Fixes issue 5979.

Patch Set 1 #

Patch Set 2 : diff -r 6423f26d0193 https://code.google.com/p/go #

Patch Set 3 : diff -r 6423f26d0193 https://code.google.com/p/go #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/net/http/response.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

josharian

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 10 months ago (2013-08-04 15:32:32 UTC) #1

bradfitz

LGTM More accurate than what we have now, but we might still want to elaborate ...

11 years, 10 months ago (2013-08-04 18:23:11 UTC) #2

bradfitz

11 years, 10 months ago (2013-08-04 18:23:24 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=cd4514beea15 ***

net/http: fix Response.Header documentation for multiple headers with same key

Whether the keys are concatenated or separate (or a mixture) depends on the
server.

Fixes issue 5979.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12433043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages